Re: [PATCH] Enable the read ECC before program the page

Greg KH
2017-09-13T21:32:20Z

On Wed, Sep 13, 2017 at 03:15:26PM -0400, Arun Nagendran wrote:
> Current program_page function did following operation:
>
> 1. read page (with ECC OFF)
> 2. modify the page
> 3. write the page (with ECC ON)
>
> For some case(buggy flash Chip), while read the page without ECC ON,
> we may read the page with bit flip error and modify that bad page without
> knowing the bit flip error on that page.
> also we re-calculate the hash for bad page and write it.
> This could bring potential in-consistency problem with Flash data.
>
> Verify this logic with GIGA DEVICE Part(GD5F2GQ4RCFIG):
> we see this in-conststency problem wit Giga Device and fix on
> this patch resovle that issue.
>
> Signed-off-by: Arun Nagendran <arunrasppi@gmail.com>

Please read Documentation/SubmittingPatches for how to properly version
your patches so we know what is going on and which one to accept/review.

Also your subject line needs some work, look at the other subjects for
patches that have been accepted for this driver/subsystem for examples
of what needs to be done.

thanks,

greg k-h