From: Arun Nagendran <arunrasppi@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: manonuevo@micron.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Enable the read ECC before program the page
Date: Thu, 14 Sep 2017 11:56:49 -0400 [thread overview]
Message-ID: <59baa6c2.52399f0a.2a6b6.e8b6@mx.google.com> (raw)
In-Reply-To: <20170913213154.GF9288@kroah.com>
On Wed, Sep 13, 2017 at 02:31:54PM -0700, Greg KH wrote:
> On Wed, Sep 13, 2017 at 03:15:26PM -0400, Arun Nagendran wrote:
> > Current program_page function did following operation:
> >
> > 1. read page (with ECC OFF)
> > 2. modify the page
> > 3. write the page (with ECC ON)
> >
> > For some case(buggy flash Chip), while read the page without ECC ON,
> > we may read the page with bit flip error and modify that bad page without
> > knowing the bit flip error on that page.
> > also we re-calculate the hash for bad page and write it.
> > This could bring potential in-consistency problem with Flash data.
> >
> > Verify this logic with GIGA DEVICE Part(GD5F2GQ4RCFIG):
> > we see this in-conststency problem wit Giga Device and fix on
> > this patch resovle that issue.
> >
> > Signed-off-by: Arun Nagendran <arunrasppi@gmail.com>
>
> Please read Documentation/SubmittingPatches for how to properly version
> your patches so we know what is going on and which one to accept/review.
>
> Also your subject line needs some work, look at the other subjects for
> patches that have been accepted for this driver/subsystem for examples
> of what needs to be done.
>
> thanks,
>
> greg k-h
Thank you Greg on your review comments, I am working on
your suggestion.
Thanks,
-Arun
next prev parent reply other threads:[~2017-09-14 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 19:15 [PATCH] Enable the read ECC before program the page Arun Nagendran
2017-09-13 21:31 ` Greg KH
2017-09-14 15:56 ` Arun Nagendran [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-13 18:34 Arun Nagendran
2017-09-13 19:04 ` Greg KH
2017-09-13 18:20 Arun Nagendran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59baa6c2.52399f0a.2a6b6.e8b6@mx.google.com \
--to=arunrasppi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manonuevo@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox