From: Md Sadre Alam <quic_mdalam@quicinc.com>
To: Gabor Juhos <j4g8y7@gmail.com>, Mark Brown <broonie@kernel.org>,
"Sricharan Ramabadhran" <quic_srichara@quicinc.com>,
Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: <linux-spi@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: spi-qpic-snand: propagate errors from qcom_spi_block_erase()
Date: Thu, 24 Apr 2025 17:01:25 +0530 [thread overview]
Message-ID: <5c860a06-48ff-554b-824b-51fdf4d51f4e@quicinc.com> (raw)
In-Reply-To: <20250423-qpic-snand-propagate-error-v1-1-4b26ed45fdb5@gmail.com>
On 4/24/2025 1:01 AM, Gabor Juhos wrote:
> The qcom_spi_block_erase() function returns with error in case of
> failure. Change the qcom_spi_send_cmdaddr() function to propagate
> these errors to the callers instead of returning with success.
>
> Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> ---
> drivers/spi/spi-qpic-snand.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
> index 17eb67e19132612c4c1a84848fa6f7432b1130a8..ae32c452d0bcf852b69b76e595f3588ea7e1a670 100644
> --- a/drivers/spi/spi-qpic-snand.c
> +++ b/drivers/spi/spi-qpic-snand.c
> @@ -1307,8 +1307,7 @@ static int qcom_spi_send_cmdaddr(struct qcom_nand_controller *snandc,
> snandc->qspi->addr1 = cpu_to_le32(s_op.addr1_reg << 16);
> snandc->qspi->addr2 = cpu_to_le32(s_op.addr2_reg);
> snandc->qspi->cmd = cpu_to_le32(cmd);
> - qcom_spi_block_erase(snandc);
> - return 0;
> + return qcom_spi_block_erase(snandc);
> default:
> break;
> }
>
> ---
> base-commit: 9c32cda43eb78f78c73aee4aa344b777714e259b
> change-id: 20250422-qpic-snand-propagate-error-9c95811ab811
Reviewed-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> Best regards,
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-04-24 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 19:31 [PATCH] spi: spi-qpic-snand: propagate errors from qcom_spi_block_erase() Gabor Juhos
2025-04-24 7:00 ` Abel Vesa
2025-04-24 11:31 ` Md Sadre Alam [this message]
2025-04-25 12:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c860a06-48ff-554b-824b-51fdf4d51f4e@quicinc.com \
--to=quic_mdalam@quicinc.com \
--cc=broonie@kernel.org \
--cc=j4g8y7@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox