From: David Brownell <david-b@pacbell.net>
To: H Hartley Sweeten <hartleys@visionengravers.com>,
Grant Likely <grant.likely@secretlab.ca>
Cc: "spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>,
David Woodhouse <dwmw2@infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Artem.Bityutskiy@nokia.com" <Artem.Bityutskiy@nokia.com>
Subject: Re: [PATCH] mtd: sst25l: fix reads with broken spi-masters
Date: Fri, 14 Jan 2011 14:34:33 -0800 (PST) [thread overview]
Message-ID: <605049.78283.qm@web180310.mail.gq1.yahoo.com> (raw)
In-Reply-To: <20110114222401.GA10504@angua.secretlab.ca>
--- On Fri, 1/14/11, Grant Likely <grant.likely@secretlab.ca> wrote:
> > The bug _is_ in the spi peripheral on the ep93xx.
> >
>
> No, David is correct. The fault is in the master
> driver. It is perfectly valid (and common) for spi
> peripherals to required the SS line to remain asserted over
> the entire transfer.
And that's what the Linux SPI stack requires,
so any master driver that doesn't keep the
slave selected during the entiretransfer is buggy.
prev parent reply other threads:[~2011-01-14 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 21:21 [PATCH] mtd: sst25l: fix reads with broken spi-masters H Hartley Sweeten
2011-01-10 22:20 ` David Brownell
2011-01-10 22:36 ` H Hartley Sweeten
2011-01-14 22:24 ` Grant Likely
2011-01-14 22:34 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=605049.78283.qm@web180310.mail.gq1.yahoo.com \
--to=david-b@pacbell.net \
--cc=Artem.Bityutskiy@nokia.com \
--cc=dwmw2@infradead.org \
--cc=grant.likely@secretlab.ca \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox