From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B823C433F5 for ; Fri, 15 Apr 2022 05:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jWDOUPYymbuVbydAuGRFddWzUdslNz4C7it8hjzFkbA=; b=t85gkblw4/96Dw s4Q/bF0EQGdCvmPAAv0Ut2LSsL31I6OAkZVUrhcZRA6mMPY1hVpRMMPeQ9ny5jbcLlEZr1b2g4HaK hF4bhH48g6PnHCiZI369QJkEFk5chumC3lkr24TIshn2vHOTZaN9WySEmZhzS3/BHoQRl6IqE6zoa haiYPP4M+wr1508EtFo548U5YA6wOJZ5CIEKLIsl3n+CP6/2EkG5xGn4w4DcSrqQYECR51AwSnpza 9+W6E6LXuBsd9MWkyuNjoNfdwDLFHAUVdJkUJYHi4CSkio4kPoZm1kZgQGWMhfQah8s5FF8z5ZkNM mL9RX+08ROu+wTp5dkxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfEFB-008bqd-Sp; Fri, 15 Apr 2022 05:11:42 +0000 Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfEDP-008avY-0A for linux-mtd@lists.infradead.org; Fri, 15 Apr 2022 05:09:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1649999390; x=1681535390; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y4PW6r0NI=; b=CMPNWyaXC+5Ao8bpY5stnytChgMrISU4YAvwAwRTkTi0Gzl9YlnYH53W FxcbA2n9y4gsMWt4S9E6o5X3beIAFZBiePehU66IAJ8uaBMt1eBhBSPYe XbKky4DtUYLfmCzTYobsWdGEsfuSD1obT+mEuGj4MLO3GzCz2PZXFdB23 p5rCD8TRMlhaKieuzkS9SlWBgh68mK/8RMqXUHb4Dw6q215lkgZuwLJXt t4071Wz1WHFmYFMOhPymV8OvF5zRaixs7azd6Kr/Spp3zFbnmf3b8tJQn mzVL60olZG8LHtOegtGOJc8j0RUb+H+NZr/xt3427qBqIsvfEPA0fFCyw A==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="196832575" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:09:48 +0800 IronPort-SDR: vVR7WGzt6Gmo/OKiUeSWIWIQeVo9pBMFq3B2gHjF2L51rkCTz8PVZPZ3PwGVbFsANvZqCEGv8G jHztj4RjetiWK8oqTW0rXmCdUlpG1/D+mga8r2pAn7w6idNIBSqRmTLxFQHnTOmhQYbYaXSBf3 rO1nX4i4HetGwG/lGsjQrgIeR+upireyY7BbrRl+Tz7szTnOxyr5Ja/Vcckzcidh63tZTcwVgE Tksk5dtS39mN7B/Kr8pJ1b+owQEd910i6BKxqiC8eylowhDvaiPzOogr0OzypY0EjNH+4DyRBg eAWqwOmqClYLnDw5bHtq5W11 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:40:13 -0700 IronPort-SDR: Ul6r60SN4Jx/Z2OZHRMT3aJgHC/ch0OckdxCaLSHtfjibIxBgoSq0k2RVYuNOlgDKhkxUmj3QI WQyALemd6ico1Aa1PGR7nyylvHGwFsTe+hWZU4bmXCxm05bhgl/aWpp4wi/5tiS0NBah/J50lc y3tAVsRWbafDh8uUHLo95uWFW9yLqIkQqPF8boZPDNDIFobvsHFz+ZNbSASFy95C0yQ1J4nY9C 5ZbjUOMEIOMTiVRcYc85QOLc8kupxASv/J8++LN7oyNQ8jT5+9zXs6r5Qn2fZMgvPtJsdXrxAg vAg= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:09:49 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KfksS1gLZz1SVp3 for ; Thu, 14 Apr 2022 22:09:48 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999387; x=1652591388; bh=wC6/PVYH+J9es8aT7sK5ZaGwsGnDQHOFu7y 4PW6r0NI=; b=A2KBgHYSLIEiloAT36KBlSnrdHo/5oKL9FrIFynJT5WRtSMAWFY bOfFXbV9aPU/SW14KWhWGoxgvZNpDxlNmySfQsvY8YKVzB0GPsCqMriDKUnvzDGe gxI79wWgz9d4ps/B6Xlf+gQiJxT1WJ1ZvXg2qG+PSKztllpdqubmLYAwOO/nz5St h4S8KA8vLEE0CNTHJjAA8Hcfkt3KCfxgWm/synsXo5jFqWGlKXVMBpl0q6F/zUl8 QMkInWk2S7O06U7jACfYKTCYPrMyVz97bbnYwKLXgej41iNgxlqjzLyt5sjDI1Lg BUEAK+PEVHrx0bfVbsoqkvKO8/sBQvwsP4Q== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id j0tAlNfSWEeM for ; Thu, 14 Apr 2022 22:09:47 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KfksM3c9Fz1Rvlx; Thu, 14 Apr 2022 22:09:43 -0700 (PDT) Message-ID: <62ebc311-e5ef-cea5-5236-0c83d1a3eb64@opensource.wdc.com> Date: Fri, 15 Apr 2022 14:09:42 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 10/27] mm: use bdev_is_zoned in claim_swapfile Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-11-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220415045258.199825-11-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_220951_188698_4C061E98 X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 4/15/22 13:52, Christoph Hellwig wrote: > Use the bdev based helper instead of poking into the queue. > > Signed-off-by: Christoph Hellwig > --- > mm/swapfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 63c61f8b26118..4c7537162af5e 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -2761,7 +2761,7 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode) > * write only restriction. Hence zoned block devices are not > * suitable for swapping. Disallow them here. > */ > - if (blk_queue_is_zoned(p->bdev->bd_disk->queue)) > + if (bdev_is_zoned(p->bdev)) > return -EINVAL; > p->flags |= SWP_BLKDEV; > } else if (S_ISREG(inode->i_mode)) { Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/