From: Krzysztof Kozlowski <krzk@kernel.org>
To: Erez <erezgeva2@gmail.com>
Cc: Erez Geva <erezgeva@nwtime.org>,
linux-mtd@lists.infradead.org,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
linux-kernel@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Esben Haabendal <esben@geanix.com>
Subject: Re: [PATCH v4 3/5] dt-bindings: mtd: spi-nor: add OTP parameters
Date: Tue, 17 Sep 2024 19:00:17 +0200 [thread overview]
Message-ID: <64ef46b1-7908-4b15-866d-9cabe2e5dc9e@kernel.org> (raw)
In-Reply-To: <CANeKEMN+ZUAGKGsqnaToDB3AxX9NN_JeCBWHwd-wwnTWLU3R+g@mail.gmail.com>
On 17/09/2024 12:42, Erez wrote:
> On Tue, 17 Sept 2024 at 12:36, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 17/09/2024 11:49, Erez Geva wrote:
>>> From: Erez Geva <ErezGeva2@gmail.com>
>>>
>>> Some flash devices need OTP parameters in device tree.
>>> As we can not deduce the parameters based on JEDEC ID or SFDP.
>>>
>>> Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
>>> ---
>>> .../bindings/mtd/jedec,spi-nor.yaml | 37 +++++++++++++++++++
>>> 1 file changed, 37 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> index 6e3afb42926e..d502b7fab2ce 100644
>>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>>> @@ -90,6 +90,43 @@ properties:
>>> the SRWD bit while writing the status register. WP# signal hard strapped to GND
>>> can be a valid use case.
>>>
>>> + opt_n_regions:
>>
>> No underscores, but hyphens.
>
> I'll fix this.
>
>>
>>> + type: u32
>>
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
>
> I run "make dt_binding_check" on kernel 6.6.
Yeah, we are no on kernel 6.6. You can run it also on kernel v4.1 -
still does not matter.
Don't develop on ancient code because then you ask us to review same
broken stuff we already fixed.
Best regards,
Krzysztof
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-09-17 17:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 9:49 [PATCH v4 0/5] Add support for SPI-NOR Macronix OTP Erez Geva
2024-09-17 9:49 ` [PATCH v4 1/5] mtd: spi-nor: core: add manufacturer flags Erez Geva
2024-09-17 9:49 ` [PATCH v4 2/5] mtd: spi-nor: core: add generic functions Erez Geva
2024-09-17 9:49 ` [PATCH v4 3/5] dt-bindings: mtd: spi-nor: add OTP parameters Erez Geva
2024-09-17 10:17 ` Erez
2024-09-17 10:35 ` Krzysztof Kozlowski
2024-09-17 10:42 ` Erez
2024-09-17 17:00 ` Krzysztof Kozlowski [this message]
2024-09-17 17:11 ` Erez
2024-09-17 17:17 ` Krzysztof Kozlowski
2024-09-17 17:24 ` Erez
2024-09-17 17:32 ` Krzysztof Kozlowski
2024-09-17 18:39 ` Erez
2024-09-17 20:39 ` Conor Dooley
2024-09-17 21:29 ` Erez
2024-09-18 8:23 ` Krzysztof Kozlowski
2024-09-18 9:46 ` Erez
2024-09-17 9:49 ` [PATCH v4 4/5] mtd: spi-nor: macronix: add support for OTP Erez Geva
2024-09-17 10:32 ` Erez
2024-09-17 9:49 ` [PATCH v4 5/5] mtd: spi-nor: macronix: add manufacturer flags Erez Geva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64ef46b1-7908-4b15-866d-9cabe2e5dc9e@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=erezgeva2@gmail.com \
--cc=erezgeva@nwtime.org \
--cc=esben@geanix.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox