From: Vignesh Raghavendra <vigneshr@ti.com>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<linux-mtd@lists.infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>,
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE
Date: Tue, 6 Aug 2024 22:46:40 +0530 [thread overview]
Message-ID: <653f0d75-c35b-4182-8378-a4f0727301f0@ti.com> (raw)
In-Reply-To: <20240731080846.257139-1-biju.das.jz@bp.renesas.com>
On 31/07/24 13:38, Biju Das wrote:
> The rpc-if-hyperflash driver can be compiled as a module, but lacks
> MODULE_DEVICE_TABLE() and will therefore not be loaded automatically.
> Fix this.
>
> Fixes: 5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> Note:
> Only compile tested. Changes are similar to [1]
> [1] https://lore.kernel.org/all/20240731072955.224125-1-biju.das.jz@bp.renesas.com/
> ---
> drivers/mtd/hyperbus/rpc-if.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/mtd/hyperbus/rpc-if.c b/drivers/mtd/hyperbus/rpc-if.c
> index b22aa57119f2..e7a28f3316c3 100644
> --- a/drivers/mtd/hyperbus/rpc-if.c
> +++ b/drivers/mtd/hyperbus/rpc-if.c
> @@ -163,9 +163,16 @@ static void rpcif_hb_remove(struct platform_device *pdev)
> pm_runtime_disable(hyperbus->rpc.dev);
> }
>
> +static const struct platform_device_id rpc_if_hyperflash_id_table[] = {
> + { .name = "rpc-if-hyperflash" },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(platform, rpc_if_hyperflash_id_table);
> +
> static struct platform_driver rpcif_platform_driver = {
> .probe = rpcif_hb_probe,
> .remove_new = rpcif_hb_remove,
> + .id_table = rpc_if_hyperflash_id_table,
> .driver = {
> .name = "rpc-if-hyperflash",
> },
--
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-08-06 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 8:08 [PATCH] mtd: hyperbus: rpc-if: Add missing MODULE_DEVICE_TABLE Biju Das
2024-07-31 8:28 ` Geert Uytterhoeven
2024-08-06 17:16 ` Vignesh Raghavendra [this message]
2024-08-23 17:31 ` Miquel Raynal
2024-10-21 9:15 ` Miquel Raynal
2024-10-21 9:20 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=653f0d75-c35b-4182-8378-a4f0727301f0@ti.com \
--to=vigneshr@ti.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox