From: Marek Vasut <marek.vasut@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>, linux-mtd@lists.infradead.org
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v3 2/5] mtd: aspeed: add memory controllers for the Aspeed AST2400 SoC
Date: Sat, 10 Dec 2016 18:30:28 +0100 [thread overview]
Message-ID: <65abc62b-6add-ff21-efc5-01075bfa0c63@gmail.com> (raw)
In-Reply-To: <30a50d6d-07c5-0ca6-2d1b-3ba46c10da49@kaod.org>
On 12/10/2016 06:18 PM, Cédric Le Goater wrote:
> On 12/10/2016 05:03 AM, Marek Vasut wrote:
>>> +/*
>>> + * The AST2400 SPI flash controller does not have a CE Control
>>> + * register. It uses the CE0 control register to set 4Byte mode at the
>>> + * controller level.
>>> + */
>>> +static void aspeed_smc_chip_set_4b_spi_2400(struct aspeed_smc_chip *chip)
>>> +{
>>> + chip->ctl_val[smc_base] |= CONTROL_IO_ADDRESS_4B;
>>> + chip->ctl_val[smc_read] |= CONTROL_IO_ADDRESS_4B;
>> How do you know the SPI NOR is in 4B mode ?
>
> in aspeed_smc_chip_setup_finish() :
>
> if (chip->nor.addr_width == 4 && info->set_4b)
> info->set_4b(chip);
>
Ahhh, great :)
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-12-10 19:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 16:49 [PATCH v3 0/5] Static memory controllers for the Aspeed SoC Cédric Le Goater
2016-12-09 16:49 ` [PATCH v3 1/5] mtd: spi-nor: add memory controllers for the Aspeed AST2500 SoC Cédric Le Goater
2016-12-10 4:01 ` Marek Vasut
2016-12-10 17:34 ` Cédric Le Goater
2016-12-10 19:08 ` Marek Vasut
2016-12-12 0:05 ` Joel Stanley
2016-12-12 5:02 ` Joel Stanley
2016-12-12 9:57 ` Cédric Le Goater
2016-12-09 16:49 ` [PATCH v3 2/5] mtd: aspeed: add memory controllers for the Aspeed AST2400 SoC Cédric Le Goater
2016-12-10 4:03 ` Marek Vasut
2016-12-10 17:18 ` Cédric Le Goater
2016-12-10 17:30 ` Marek Vasut [this message]
2016-12-12 0:10 ` Joel Stanley
2016-12-09 16:49 ` [PATCH v3 3/5] mtd: aspeed: used a label property Cédric Le Goater
2016-12-10 4:03 ` Marek Vasut
2016-12-10 17:16 ` Cédric Le Goater
2016-12-11 23:46 ` Joel Stanley
2016-12-12 2:27 ` Marek Vasut
2016-12-12 9:18 ` Cédric Le Goater
2016-12-09 16:49 ` [PATCH v3 4/5] mtd: spi-nor: bindings for the Aspeed memory controllers Cédric Le Goater
2016-12-12 0:13 ` Joel Stanley
2016-12-09 16:49 ` [PATCH v3 5/5] mtd: spi-nor: add a label property to jedec,spi-nor Cédric Le Goater
2016-12-11 23:47 ` [PATCH v3 5/5] mtd: spi-nor: add a label property to jedec, spi-nor Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65abc62b-6add-ff21-efc5-01075bfa0c63@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=clg@kaod.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=joel@jms.id.au \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).