public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Kenneth Johansson <ken@kenjo.org>, bbrezillon@kernel.org
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: rawnand: nandsim: Add support to disable subpage writes.
Date: Thu, 03 Jan 2019 21:43:13 +0100	[thread overview]
Message-ID: <6672633.KqxhzBgVKO@blindfold> (raw)
In-Reply-To: <10756fcb-b284-5465-ed5c-8251cb00d9c2@kenjo.org>

Kenneth,

Am Samstag, 22. Dezember 2018, 13:53:39 CET schrieb Kenneth Johansson:
> So there was a comment from Richard on the original patch that got 
> mangled so it did not even have a subject line.
> 
> The original intent for this patch was to make it possible to setup the 
> simulator with the same parameters as some real hardware.
> That is the command "mtdinfo /dev/mtdX" would show the same on the 
> simulator as the real hardware.

Just to make sure: nandsim simulates a given NAND chip but the simulated
NAND flash controller will always be different.
Think of ECC layout.

In this case it may be good enough to fool your userspace, but don't
count on it.
 
> It's true that you could change the vid offset with ubiattach but that 
> require you know that the LEB missmatch error you get is fixed by a 
> different vid offset and you need to understand what that value should be.
> This way you only need to match the basic mtd parameters and the rest 
> will just work automatically.

I agree that adding a parameter to nandsim to control subpage behavior
is nice.
But please keep in mind that nandsim will never perfectly match your hardware.

Boris, unless you have objections I'm fine to control NAND_NO_SUBPAGE_WRITE
in nandsim using a module parameter.

Thanks,
//richard

  reply	other threads:[~2019-01-03 20:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-22 12:40 [PATCH v2] mtd: rawnand: nandsim: Add support to disable subpage writes Kenneth Johansson
2018-12-22 12:53 ` Kenneth Johansson
2019-01-03 20:43   ` Richard Weinberger [this message]
2019-01-04  8:53     ` Boris Brezillon
2019-01-04  9:01       ` Boris Brezillon
2020-09-23 14:58       ` Marc Kleine-Budde
2020-09-24  6:31         ` Richard Weinberger
2020-09-24  7:40           ` Marc Kleine-Budde
2020-09-24 10:28             ` Richard Weinberger
2020-09-24 10:56               ` Marc Kleine-Budde
2019-01-07  6:38     ` Kenneth Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6672633.KqxhzBgVKO@blindfold \
    --to=richard@nod.at \
    --cc=bbrezillon@kernel.org \
    --cc=ken@kenjo.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox