From: "Jared Hulbert" <jaredeh@gmail.com>
To: "Josh Boyer" <jdub@us.ibm.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] CORE: adding mtd_get_partition_physaddr()
Date: Tue, 29 Aug 2006 12:37:28 -0700 [thread overview]
Message-ID: <6934efce0608291237m7779c57dj23ebc8435c8f43ea@mail.gmail.com> (raw)
In-Reply-To: <1156871627.2003.15.camel@zod.rchland.ibm.com>
> > +void * mtd_get_partition_physaddr (struct mtd_info *mtd)
>
> Nit: No space between the paren and the function name please.
oops
> > +extern void * mtd_get_partition_physaddr(struct mtd_info *mtd);
>
> Couldn't this be a proper prototype instead of an extern?
I thought EXPORT_SYMBOL_GPL() implied it should be extern. Is that incorrect?
next prev parent reply other threads:[~2006-08-29 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 4:44 [PATCH] CORE: adding mtd_get_partition_physaddr() Jared Hulbert
2006-08-29 17:13 ` Josh Boyer
2006-08-29 19:37 ` Jared Hulbert [this message]
2006-08-30 12:32 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6934efce0608291237m7779c57dj23ebc8435c8f43ea@mail.gmail.com \
--to=jaredeh@gmail.com \
--cc=jdub@us.ibm.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox