public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: "Jared Hulbert" <jaredeh@gmail.com>
To: "Jörn Engel" <joern@logfs.org>
Cc: dhowells <dhowells@redhat.com>, Carsten Otte <cotte@de.ibm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH][MTD] mtdpart.c: allow other drivers to get physical address of partition
Date: Thu, 2 Aug 2007 22:23:47 -0700	[thread overview]
Message-ID: <6934efce0708022223w4e49264o29347d91e88d62f7@mail.gmail.com> (raw)
In-Reply-To: <20070803030144.GA16512@lazybastard.org>

> Interestingly __iomem makes less sense for some RAM-based drivers.  So
> maybe that part should get removed.

(http://marc.info/?l=linux-arm-kernel&m=118193919321290&w=4)
  Russel King said:
-->
-->   const void *start = virt + offset;
-->
--> This will generate a sparse warning (since you haven't used sparse you
--> won't know about this.)  The __iomem annotation does nothing as far as
--> the C language goes, but sparse uses it to annotate variables as to
--> which address space they refer to, and issues warnings if you try to
--> cast between different address spaces.  However, it does allow code
--> which knows what it's doing to do such casts.
-->
-->   const void *start = (void __force *)virt + offset;
-->
--> MTD people may like to make a note that the 'cached' element of struct
--> map_info is assigned __iomem pointers (from ioremap_cached) but is
--> itself not marked with an __iomem pointer.  This will also produce
--> sparse warnings.

Now I think maybe it should be "void **virt" not "void __iomem **virt"
and then just __force virt.  Anybody know?

> The whole patch was just a quick hack to get an opinion.

Trying to move it forward...

  reply	other threads:[~2007-08-03  5:30 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27  0:04 [PATCH][MTD] mtdpart.c: allow other drivers to get physical address of partition Jared Hulbert
2007-07-27 13:48 ` Jörn Engel
2007-07-27 17:05   ` Jared Hulbert
2007-07-27 17:44     ` Jörn Engel
2007-07-27 20:53       ` Jared Hulbert
2007-07-28 11:43         ` Jörn Engel
2007-07-28 21:08           ` Jared Hulbert
2007-07-31 11:55 ` David Woodhouse
2007-07-31 19:55   ` Jared Hulbert
2007-08-01 11:55     ` Jörn Engel
2007-08-03  1:56       ` Jared Hulbert
2007-08-03  3:01         ` Jörn Engel
2007-08-03  5:23           ` Jared Hulbert [this message]
2007-08-03  9:21             ` Jörn Engel
2007-08-03  6:42       ` Jared Hulbert
2007-08-03 12:47         ` Jörn Engel
2007-08-03 22:29           ` Jared Hulbert
2007-08-01 12:18     ` Jörn Engel
2007-08-01 12:59       ` Carsten Otte
2007-08-01 20:37         ` Jared Hulbert
2007-08-01 23:31           ` Jörn Engel
2007-08-02  7:53           ` Carsten Otte
2007-08-02 21:55             ` Jared Hulbert
2007-08-03  7:59               ` Carsten Otte
2007-08-03  9:17                 ` Jörn Engel
2007-08-03 11:03                   ` Carsten Otte
2007-08-03 11:31                     ` Jörn Engel
2007-08-03 12:21                       ` Carsten Otte
2007-08-03 12:58                         ` Jörn Engel
2007-08-03 13:09               ` David Woodhouse
2007-08-03 13:18                 ` Jörn Engel
2007-08-03 19:45                   ` Jared Hulbert
2007-08-03 23:02                     ` Jörn Engel
2007-08-04 12:33                     ` David Woodhouse
2007-08-04 17:47                       ` Jared Hulbert
2007-08-06  6:30                     ` Carsten Otte
2007-08-03 18:39                 ` Jared Hulbert
2007-08-06  6:23                 ` Carsten Otte
2007-08-01 18:03       ` Jared Hulbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6934efce0708022223w4e49264o29347d91e88d62f7@mail.gmail.com \
    --to=jaredeh@gmail.com \
    --cc=cotte@de.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=joern@logfs.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox