Re: MTD CVS update: 'mtd/kernel pmc551.c'

Re: MTD CVS update: 'mtd/kernel pmc551.c'

[David Woodhouse]

bjorn@pobox.com said:
> The egcs-2.91.66 optimiser gets confused in pmc551.c:init_pmc551() if
> PCI support is disabled in the kernel config. 

It shouldn't be built if !CONFIG_PCI. Config.in doesn't let you enable it. 
P'raps we should do something similar for the standalone Makefile.

--
dwmw2




To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

cfi_amdext_sync, cfi_intelext_sync

[Alice Hennessy]

Hi,

Found a bug in cfi_cmdset_0001.c and  cfi_cmdset_0002.c in functions
cfi_intelext_sync and cfi_amdext_sync respectively.  The call to
remove_wait_queue is missing after the "add_wait_queue;spin_unlock_bh;
schedule"   sequence in the default case.

The gory details:   Our test caused erase and sync to be called
concurrently.    The sync code sees the chip state as FL_ERASING  and
correctly calls add_wait_queue.  The problem is that remove_wait_queue is
never called after the schedule.  This causes  wait's task_list to be added
to chip->wq's task_list several times which results in an incorrect circular
list.   The final outcome is a hang when the erase logic calls wake_up which
ends up in an infinite loop running through chip->wq's task_list.  A nice
touch is that we are in spin_lock_bh so the system hangs as well.

If you agree, should I check in the fix?

Alice



To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org

Re: cfi_amdext_sync, cfi_intelext_sync

[David Woodhouse]

On Fri, 6 Oct 2000, Alice Hennessy wrote:

> Hi,
> 
> Found a bug in cfi_cmdset_0001.c and  cfi_cmdset_0002.c in functions
> cfi_intelext_sync and cfi_amdext_sync respectively.  The call to
> remove_wait_queue is missing after the "add_wait_queue;spin_unlock_bh;
> schedule"   sequence in the default case.

Doh! Well spotted. 

> A nice touch is that we are in spin_lock_bh so the system hangs as well.

Thinks.... it's too early in the morning for me to decide whether it's
safe to drop the lock _before_ calling wake_up(). Probably. 

> If you agree, should I check in the fix?

Yes please.

-- 
dwmw2




To unsubscribe, send "unsubscribe mtd" to majordomo@infradead.org