From: Michael Walle <michael@walle.cc>
To: Jaime Liao <jaimeliao.tw@gmail.com>
Cc: linux-mtd@lists.infradead.org, tudor.ambarus@linaro.org,
pratyush@kernel.org, miquel.raynal@bootlin.com,
leoyu@mxic.com.tw, jaimeliao@mxic.com.tw
Subject: Re: [PATCH v1 2/2] mtd: spi-nor: hide flash name when the flash name does not exist
Date: Mon, 27 Nov 2023 13:21:34 +0100 [thread overview]
Message-ID: <6d362dd698095b04dd895019d3af26d0@walle.cc> (raw)
In-Reply-To: <20231127100756.41605-3-jaimeliao.tw@gmail.com>
Hi,
> (null) will print when flash ID founded in ID table but
> the flash name didn't include in it.
>
> Make info->name optional in the print for showing flash name
> and flash size.
>
> Signed-off-by: JaimeLiao <jaimeliao@mxic.com.tw>
> ---
> drivers/mtd/spi-nor/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 1c443fe568cf..73405bed2a5a 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3518,7 +3518,7 @@ int spi_nor_scan(struct spi_nor *nor, const char
> *name,
> /* No mtd_info fields should be used up to this point. */
> spi_nor_set_mtd_info(nor);
>
> - dev_info(dev, "%s (%lld Kbytes)\n", info->name,
> + dev_info(dev, "%s (%lld Kbytes)\n", info->name ?: "",
Maybe print the jedec id if the name is empty.
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-11-27 12:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:07 [PATCH v1 0/2] Hide flash name if it is not set Jaime Liao
2023-11-27 10:07 ` [PATCH v1 1/2] mtd: spi-nor:sysfs: hide " Jaime Liao
2023-11-27 10:07 ` [PATCH v1 2/2] mtd: spi-nor: hide flash name when the flash name does not exist Jaime Liao
2023-11-27 12:21 ` Michael Walle [this message]
2023-11-27 14:47 ` Miquel Raynal
2023-11-27 14:56 ` Michael Walle
2023-11-27 15:21 ` Tudor Ambarus
2023-11-27 15:28 ` Michael Walle
2023-11-27 17:06 ` Tudor Ambarus
2023-11-27 11:49 ` [PATCH v1 0/2] Hide flash name if it is not set Miquel Raynal
2023-11-27 11:58 ` Michael Walle
2023-11-27 12:03 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d362dd698095b04dd895019d3af26d0@walle.cc \
--to=michael@walle.cc \
--cc=jaimeliao.tw@gmail.com \
--cc=jaimeliao@mxic.com.tw \
--cc=leoyu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox