Re: [PATCH v1 2/2] mtd: spi-nor: hide flash name when the flash name does not exist

Michael Walle
2023-11-27T12:21:50Z

Hi,

> (null) will print when flash ID founded in ID table but
> the flash name didn't include in it.
>
> Make info->name optional in the print for showing flash name
> and flash size.
>
> Signed-off-by: JaimeLiao <jaimeliao@mxic.com.tw>
> ---
> drivers/mtd/spi-nor/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 1c443fe568cf..73405bed2a5a 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -3518,7 +3518,7 @@ int spi_nor_scan(struct spi_nor *nor, const char
> *name,
> /* No mtd_info fields should be used up to this point. */
> spi_nor_set_mtd_info(nor);
>
> - dev_info(dev, "%s (%lld Kbytes)\n", info->name,
> + dev_info(dev, "%s (%lld Kbytes)\n", info->name ?: "",

Maybe print the jedec id if the name is empty.

-michael