Re: [PATCH v2 0/4] Add Rockchip SFC(serial flash controller) support

From: Michael Walle <michael@walle.cc>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-mtd@lists.infradead.org,
	linux-rockchip@lists.infradead.org, andy.yan@rock-chips.com,
	yifeng.zhao@rock-chips.com, sugar.zhang@rock-chips.com,
	tudor.ambarus@microchip.com, p.yadav@ti.com, heiko@sntech.de,
	robh+dt@kernel.org, vigneshr@ti.com, richard@nod.at,
	miquel.raynal@bootlin.com, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v2 0/4] Add Rockchip SFC(serial flash controller) support
Date: Fri, 28 May 2021 20:49:53 +0200	[thread overview]
Message-ID: <6d849f2fd9c6ca3389fa98f4ae8e8069@walle.cc> (raw)
In-Reply-To: <20210528170020.26219-1-macroalpha82@gmail.com>

Am 2021-05-28 19:00, schrieb Chris Morgan:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> I'm trying to revive an abandoned patch series for the Rockchip serial
> flash controller (SFC) found on the Rockchip PX30 SOC, as well as other
> SOCs by Rockchip. I'm picking this up from version 8 of the patch
> series located from here:
> 
> http://patchwork.ozlabs.org/project/linux-mtd/cover/1518091958-3672-1-git-send-email-andy.yan@rock-chips.com/
> 
> Changes made in v2:
>  - Reimplemented driver using spi-mem subsystem.

Nice!

Oh and I forgot, the dt-bindings patch should go first.

-michael

>  - Removed power management code as I couldn't get it working properly.
>  - Added device tree bindings for Odroid Go Advance.
> 
> Changes made in this new series versus the v8 of the old series:
>  - Added function to read spi-rx-bus-width from device tree, in the
>    event that the SPI chip supports 4x mode but only has 2 pins
>    wired (such as the Odroid Go Advance).
>  - Changed device tree documentation from txt to yaml format.
>  - Made "reset" message a dev_dbg from a dev_info.
>  - Changed read and write fifo functions to remove redundant checks.
>  - Changed the write and read from relaxed to non-relaxed when
>    starting the DMA transfer or reading the DMA IRQ.
>  - Changed from dma_coerce_mask_and_coherent to just
>    dma_set_mask_and_coherent.
>  - Changed name of get_if_type to rockchip_sfc_get_if_type.
> 
> Chris Morgan (4):
>   spi: rockchip-sfc: add rockchip serial flash controller driver
>   spi: rockchip-sfc: Bindings for Rockchip serial flash controller
>   arm64: dts: rockchip: Add SFC to PX30
>   arm64: dts: rockchip: Enable SFC for Odroid Go Advance
> 
>  .../spi/rockchip,serialflash-controller.yaml  | 107 +++
>  arch/arm64/boot/dts/rockchip/px30.dtsi        |  38 +
>  .../boot/dts/rockchip/rk3326-odroid-go2.dts   |  16 +
>  drivers/spi/Kconfig                           |   9 +
>  drivers/spi/Makefile                          |   1 +
>  drivers/spi/spi-rockchip-sfc.c                | 856 ++++++++++++++++++
>  6 files changed, 1027 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/spi/rockchip,serialflash-controller.yaml
>  create mode 100644 drivers/spi/spi-rockchip-sfc.c

-- 
-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/