From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa2.microchip.iphmx.com ([68.232.149.84]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUE4b-00062k-Tq for linux-mtd@lists.infradead.org; Tue, 04 Dec 2018 17:01:27 +0000 From: To: , CC: , , , Subject: Re: [PATCH v2 1/6] mtd: spi-nor: Drop inline on all internal helpers Date: Tue, 4 Dec 2018 17:01:10 +0000 Message-ID: <6e3c6eb7-99f1-b236-4789-8a278acb4b1c@microchip.com> References: <20181129141026.24892-1-boris.brezillon@bootlin.com> <20181129141026.24892-2-boris.brezillon@bootlin.com> In-Reply-To: <20181129141026.24892-2-boris.brezillon@bootlin.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , DQoNCk9uIDExLzI5LzIwMTggMDQ6MTAgUE0sIEJvcmlzIEJyZXppbGxvbiB3cm90ZToNCj4gZ2Nj IHNob3VsZCBiZSBzbWFydCBlbm91Z2ggdG8gZGVjaWRlIHdoZW4gaW5saW5pbmcgYSBmdW5jdGlv biBtYWtlcw0KPiBzZW5zZS4gRHJvcCBhbGwgaW5saW5lIHNwZWNpZmllcnMuDQo+IA0KPiBTaWdu ZWQtb2ZmLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4N Cg0KUmV2aWV3ZWQtYnk6IFR1ZG9yIEFtYmFydXMgPHR1ZG9yLmFtYmFydXNAbWljcm9jaGlwLmNv bT4NCg0KPiAtLS0NCj4gQ2hhbmdlcyBpbiB2MjoNCj4gLSBOb25lDQo+IC0tLQ0KPiAgZHJpdmVy cy9tdGQvc3BpLW5vci9zcGktbm9yLmMgfCAyNCArKysrKysrKysrKystLS0tLS0tLS0tLS0NCj4g IDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkNCj4gDQo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9zcGktbm9yL3NwaS1ub3IuYyBiL2RyaXZlcnMvbXRk L3NwaS1ub3Ivc3BpLW5vci5jDQo+IGluZGV4IDgyOGQwM2VkYzBhMy4uMGFhMWIxMDM1YjRiIDEw MDY0NA0KPiAtLS0gYS9kcml2ZXJzL210ZC9zcGktbm9yL3NwaS1ub3IuYw0KPiArKysgYi9kcml2 ZXJzL210ZC9zcGktbm9yL3NwaS1ub3IuYw0KPiBAQCAtMTU5LDcgKzE1OSw3IEBAIHN0YXRpYyBp bnQgcmVhZF9jcihzdHJ1Y3Qgc3BpX25vciAqbm9yKQ0KPiAgICogV3JpdGUgc3RhdHVzIHJlZ2lz dGVyIDEgYnl0ZQ0KPiAgICogUmV0dXJucyBuZWdhdGl2ZSBpZiBlcnJvciBvY2N1cnJlZC4NCj4g ICAqLw0KPiAtc3RhdGljIGlubGluZSBpbnQgd3JpdGVfc3Ioc3RydWN0IHNwaV9ub3IgKm5vciwg dTggdmFsKQ0KPiArc3RhdGljIGludCB3cml0ZV9zcihzdHJ1Y3Qgc3BpX25vciAqbm9yLCB1OCB2 YWwpDQo+ICB7DQo+ICAJbm9yLT5jbWRfYnVmWzBdID0gdmFsOw0KPiAgCXJldHVybiBub3ItPndy aXRlX3JlZyhub3IsIFNQSU5PUl9PUF9XUlNSLCBub3ItPmNtZF9idWYsIDEpOw0KPiBAQCAtMTY5 LDcgKzE2OSw3IEBAIHN0YXRpYyBpbmxpbmUgaW50IHdyaXRlX3NyKHN0cnVjdCBzcGlfbm9yICpu b3IsIHU4IHZhbCkNCj4gICAqIFNldCB3cml0ZSBlbmFibGUgbGF0Y2ggd2l0aCBXcml0ZSBFbmFi bGUgY29tbWFuZC4NCj4gICAqIFJldHVybnMgbmVnYXRpdmUgaWYgZXJyb3Igb2NjdXJyZWQuDQo+ ICAgKi8NCj4gLXN0YXRpYyBpbmxpbmUgaW50IHdyaXRlX2VuYWJsZShzdHJ1Y3Qgc3BpX25vciAq bm9yKQ0KPiArc3RhdGljIGludCB3cml0ZV9lbmFibGUoc3RydWN0IHNwaV9ub3IgKm5vcikNCj4g IHsNCj4gIAlyZXR1cm4gbm9yLT53cml0ZV9yZWcobm9yLCBTUElOT1JfT1BfV1JFTiwgTlVMTCwg MCk7DQo+ICB9DQo+IEBAIC0xNzcsMTIgKzE3NywxMiBAQCBzdGF0aWMgaW5saW5lIGludCB3cml0 ZV9lbmFibGUoc3RydWN0IHNwaV9ub3IgKm5vcikNCj4gIC8qDQo+ICAgKiBTZW5kIHdyaXRlIGRp c2FibGUgaW5zdHJ1Y3Rpb24gdG8gdGhlIGNoaXAuDQo+ICAgKi8NCj4gLXN0YXRpYyBpbmxpbmUg aW50IHdyaXRlX2Rpc2FibGUoc3RydWN0IHNwaV9ub3IgKm5vcikNCj4gK3N0YXRpYyBpbnQgd3Jp dGVfZGlzYWJsZShzdHJ1Y3Qgc3BpX25vciAqbm9yKQ0KPiAgew0KPiAgCXJldHVybiBub3ItPndy aXRlX3JlZyhub3IsIFNQSU5PUl9PUF9XUkRJLCBOVUxMLCAwKTsNCj4gIH0NCj4gIA0KPiAtc3Rh dGljIGlubGluZSBzdHJ1Y3Qgc3BpX25vciAqbXRkX3RvX3NwaV9ub3Ioc3RydWN0IG10ZF9pbmZv ICptdGQpDQo+ICtzdGF0aWMgc3RydWN0IHNwaV9ub3IgKm10ZF90b19zcGlfbm9yKHN0cnVjdCBt dGRfaW5mbyAqbXRkKQ0KPiAgew0KPiAgCXJldHVybiBtdGQtPnByaXY7DQo+ICB9DQo+IEBAIC0y MDAsNyArMjAwLDcgQEAgc3RhdGljIHU4IHNwaV9ub3JfY29udmVydF9vcGNvZGUodTggb3Bjb2Rl LCBjb25zdCB1OCB0YWJsZVtdWzJdLCBzaXplX3Qgc2l6ZSkNCj4gIAlyZXR1cm4gb3Bjb2RlOw0K PiAgfQ0KPiAgDQo+IC1zdGF0aWMgaW5saW5lIHU4IHNwaV9ub3JfY29udmVydF8zdG80X3JlYWQo dTggb3Bjb2RlKQ0KPiArc3RhdGljIHU4IHNwaV9ub3JfY29udmVydF8zdG80X3JlYWQodTggb3Bj b2RlKQ0KPiAgew0KPiAgCXN0YXRpYyBjb25zdCB1OCBzcGlfbm9yXzN0bzRfcmVhZFtdWzJdID0g ew0KPiAgCQl7IFNQSU5PUl9PUF9SRUFELAlTUElOT1JfT1BfUkVBRF80QiB9LA0KPiBAQCAtMjE5 LDcgKzIxOSw3IEBAIHN0YXRpYyBpbmxpbmUgdTggc3BpX25vcl9jb252ZXJ0XzN0bzRfcmVhZCh1 OCBvcGNvZGUpDQo+ICAJCQkJICAgICAgQVJSQVlfU0laRShzcGlfbm9yXzN0bzRfcmVhZCkpOw0K PiAgfQ0KPiAgDQo+IC1zdGF0aWMgaW5saW5lIHU4IHNwaV9ub3JfY29udmVydF8zdG80X3Byb2dy YW0odTggb3Bjb2RlKQ0KPiArc3RhdGljIHU4IHNwaV9ub3JfY29udmVydF8zdG80X3Byb2dyYW0o dTggb3Bjb2RlKQ0KPiAgew0KPiAgCXN0YXRpYyBjb25zdCB1OCBzcGlfbm9yXzN0bzRfcHJvZ3Jh bVtdWzJdID0gew0KPiAgCQl7IFNQSU5PUl9PUF9QUCwJCVNQSU5PUl9PUF9QUF80QiB9LA0KPiBA QCAtMjMxLDcgKzIzMSw3IEBAIHN0YXRpYyBpbmxpbmUgdTggc3BpX25vcl9jb252ZXJ0XzN0bzRf cHJvZ3JhbSh1OCBvcGNvZGUpDQo+ICAJCQkJICAgICAgQVJSQVlfU0laRShzcGlfbm9yXzN0bzRf cHJvZ3JhbSkpOw0KPiAgfQ0KPiAgDQo+IC1zdGF0aWMgaW5saW5lIHU4IHNwaV9ub3JfY29udmVy dF8zdG80X2VyYXNlKHU4IG9wY29kZSkNCj4gK3N0YXRpYyB1OCBzcGlfbm9yX2NvbnZlcnRfM3Rv NF9lcmFzZSh1OCBvcGNvZGUpDQo+ICB7DQo+ICAJc3RhdGljIGNvbnN0IHU4IHNwaV9ub3JfM3Rv NF9lcmFzZVtdWzJdID0gew0KPiAgCQl7IFNQSU5PUl9PUF9CRV80SywJU1BJTk9SX09QX0JFXzRL XzRCIH0sDQo+IEBAIC0yNzYsOCArMjc2LDggQEAgc3RhdGljIHZvaWQgc3BpX25vcl9zZXRfNGJ5 dGVfb3Bjb2RlcyhzdHJ1Y3Qgc3BpX25vciAqbm9yLA0KPiAgfQ0KPiAgDQo+ICAvKiBFbmFibGUv ZGlzYWJsZSA0LWJ5dGUgYWRkcmVzc2luZyBtb2RlLiAqLw0KPiAtc3RhdGljIGlubGluZSBpbnQg c2V0XzRieXRlKHN0cnVjdCBzcGlfbm9yICpub3IsIGNvbnN0IHN0cnVjdCBmbGFzaF9pbmZvICpp bmZvLA0KPiAtCQkJICAgIGludCBlbmFibGUpDQo+ICtzdGF0aWMgaW50IHNldF80Ynl0ZShzdHJ1 Y3Qgc3BpX25vciAqbm9yLCBjb25zdCBzdHJ1Y3QgZmxhc2hfaW5mbyAqaW5mbywNCj4gKwkJICAg ICBpbnQgZW5hYmxlKQ0KPiAgew0KPiAgCWludCBzdGF0dXM7DQo+ICAJYm9vbCBuZWVkX3dyZW4g PSBmYWxzZTsNCj4gQEAgLTMzNSw3ICszMzUsNyBAQCBzdGF0aWMgaW50IHMzYW5fc3JfcmVhZHko c3RydWN0IHNwaV9ub3IgKm5vcikNCj4gIAlyZXR1cm4gISEodmFsICYgWFNSX1JEWSk7DQo+ICB9 DQo+ICANCj4gLXN0YXRpYyBpbmxpbmUgaW50IHNwaV9ub3Jfc3JfcmVhZHkoc3RydWN0IHNwaV9u b3IgKm5vcikNCj4gK3N0YXRpYyBpbnQgc3BpX25vcl9zcl9yZWFkeShzdHJ1Y3Qgc3BpX25vciAq bm9yKQ0KPiAgew0KPiAgCWludCBzciA9IHJlYWRfc3Iobm9yKTsNCj4gIAlpZiAoc3IgPCAwKQ0K PiBAQCAtMzU0LDcgKzM1NCw3IEBAIHN0YXRpYyBpbmxpbmUgaW50IHNwaV9ub3Jfc3JfcmVhZHko c3RydWN0IHNwaV9ub3IgKm5vcikNCj4gIAlyZXR1cm4gIShzciAmIFNSX1dJUCk7DQo+ICB9DQo+ ICANCj4gLXN0YXRpYyBpbmxpbmUgaW50IHNwaV9ub3JfZnNyX3JlYWR5KHN0cnVjdCBzcGlfbm9y ICpub3IpDQo+ICtzdGF0aWMgaW50IHNwaV9ub3JfZnNyX3JlYWR5KHN0cnVjdCBzcGlfbm9yICpu b3IpDQo+ICB7DQo+ICAJaW50IGZzciA9IHJlYWRfZnNyKG5vcik7DQo+ICAJaWYgKGZzciA8IDAp DQo+IEBAIC0yMzcyLDcgKzIzNzIsNyBAQCBzdHJ1Y3Qgc2ZkcF9iZnB0IHsNCj4gIA0KPiAgLyog RmFzdCBSZWFkIHNldHRpbmdzLiAqLw0KPiAgDQo+IC1zdGF0aWMgaW5saW5lIHZvaWQNCj4gK3N0 YXRpYyB2b2lkDQo+ICBzcGlfbm9yX3NldF9yZWFkX3NldHRpbmdzX2Zyb21fYmZwdChzdHJ1Y3Qg c3BpX25vcl9yZWFkX2NvbW1hbmQgKnJlYWQsDQo+ICAJCQkJICAgIHUxNiBoYWxmLA0KPiAgCQkJ CSAgICBlbnVtIHNwaV9ub3JfcHJvdG9jb2wgcHJvdG8pDQo+IA0K