public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Rickard Andersson <rickard.andersson@axis.com>, <richard@nod.at>,
	<linux-mtd@lists.infradead.org>, <rickard314.andersson@gmail.com>
Cc: <kernel@axis.com>
Subject: Re: [PATCH v2 04/10] ubi: Expose mean erase counter for data in sysfs
Date: Fri, 11 Oct 2024 20:04:04 +0800	[thread overview]
Message-ID: <6fad01e9-9b93-ed79-183a-fb2011c9ec97@huawei.com> (raw)
In-Reply-To: <20241011092134.2909496-4-rickard.andersson@axis.com>

在 2024/10/11 17:21, Rickard Andersson 写道:
> Expose mean erase counter for data area in sysfs. Data area includes
> all blocks except for the fastmap area.
> 
> This value can be used in order to estimate life expectancy of the
> flash.
> 
> Signed-off-by: Rickard Andersson <rickard.andersson@axis.com>
> ---
>   drivers/mtd/ubi/build.c | 5 +++++
>   1 file changed, 5 insertions(+)

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> 
> diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
> index f5a3a3f7d490..b253dcf849c7 100644
> --- a/drivers/mtd/ubi/build.c
> +++ b/drivers/mtd/ubi/build.c
> @@ -138,6 +138,8 @@ static struct device_attribute dev_max_ec_fastmap =
>   	__ATTR(max_ec_fastmap, S_IRUGO, dev_attribute_show, NULL);
>   static struct device_attribute dev_mean_ec_fastmap =
>   	__ATTR(mean_ec_fastmap, S_IRUGO, dev_attribute_show, NULL);
> +static struct device_attribute dev_mean_ec_data =
> +	__ATTR(mean_ec_data, S_IRUGO, dev_attribute_show, NULL);
>   #endif
>   static struct device_attribute dev_reserved_for_bad =
>   	__ATTR(reserved_for_bad, S_IRUGO, dev_attribute_show, NULL);
> @@ -463,6 +465,8 @@ static ssize_t dev_attribute_show(struct device *dev,
>   		ret = sprintf(buf, "%d\n", ubi_calc_max_ec(ubi, 0, UBI_FM_MAX_START));
>   	else if (attr == &dev_mean_ec_fastmap)
>   		ret = sprintf(buf, "%d\n", ubi_calc_mean_ec(ubi, 0, UBI_FM_MAX_START));
> +	else if (attr == &dev_mean_ec_data)
> +		ret = sprintf(buf, "%d\n", ubi_calc_mean_ec(ubi, UBI_FM_MAX_START, ubi->peb_count));
>   #endif
>   	else if (attr == &dev_reserved_for_bad)
>   		ret = sprintf(buf, "%d\n", ubi->beb_rsvd_pebs);
> @@ -494,6 +498,7 @@ static struct attribute *ubi_dev_attrs[] = {
>   #ifdef CONFIG_MTD_UBI_FASTMAP
>   	&dev_max_ec_fastmap.attr,
>   	&dev_mean_ec_fastmap.attr,
> +	&dev_mean_ec_data.attr,
>   #endif
>   	&dev_reserved_for_bad.attr,
>   	&dev_bad_peb_count.attr,
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-10-11 12:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  9:21 [PATCH v2 01/10] ubi: Expose mean erase counter in sysfs Rickard Andersson
2024-10-11  9:21 ` [PATCH v2 02/10] ubi: Expose mean erase counter for fastmap " Rickard Andersson
2024-10-11 12:02   ` Zhihao Cheng
2024-10-11  9:21 ` [PATCH v2 03/10] ubi: Expose max " Rickard Andersson
2024-10-11 12:03   ` Zhihao Cheng
2024-10-11  9:21 ` [PATCH v2 04/10] ubi: Expose mean erase counter for data " Rickard Andersson
2024-10-11 12:04   ` Zhihao Cheng [this message]
2024-10-11  9:21 ` [PATCH v2 05/10] ubi: Expose max " Rickard Andersson
2024-10-11 12:04   ` Zhihao Cheng
2024-10-11  9:21 ` [PATCH v2 06/10] ubi: Add mean erase counter sysfs attribute Rickard Andersson
2024-10-11 12:06   ` Zhihao Cheng
2024-10-11  9:21 ` [PATCH v2 07/10] ubi: Add mean erase counter sysfs attribute for fastmap area Rickard Andersson
2024-10-11 12:06   ` Zhihao Cheng
2024-10-11  9:21 ` [PATCH v2 08/10] ubi: Add max " Rickard Andersson
2024-10-11 12:06   ` Zhihao Cheng
2024-10-11  9:21 ` [PATCH v2 09/10] ubi: Add mean erase counter sysfs attribute for data area Rickard Andersson
2024-10-11 12:08   ` Zhihao Cheng
2024-10-11  9:21 ` [PATCH v2 10/10] ubi: Add max " Rickard Andersson
2024-10-11 12:08   ` Zhihao Cheng
2024-10-11 12:01 ` [PATCH v2 01/10] ubi: Expose mean erase counter in sysfs Zhihao Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fad01e9-9b93-ed79-183a-fb2011c9ec97@huawei.com \
    --to=chengzhihao1@huawei.com \
    --cc=kernel@axis.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=rickard.andersson@axis.com \
    --cc=rickard314.andersson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox