From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] mtd: cfi: don't warn about broken geometry for !CONFIG_MTD Date: Tue, 24 Nov 2015 23:09:02 +0100 Message-ID: <7025557.qur2fOT79A@wuerfel> In-Reply-To: <4492128.vrqmf1niG3@wuerfel> References: <3747078.dk5V5gxuXa@wuerfel> <4492128.vrqmf1niG3@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The linux/mtd/map.h header file is included by a couple of platform specific files that are built even when CONFIG_MTD is disabled, and we always get warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work" in that case. This adds an #ifdef around the pointless warning, as everything is really fine when we don't build the drivers anyway. Signed-off-by: Arnd Bergmann --- > I'm actually still getting the warnings for any file that includes > while CONFIG_MTD is disabled. I have a fix now that I'm testing overnight > and plan to post tomorrow, then we can decide whether it should be part of > the same patch, or we should have two separate patches. The patch fixes the remaining warnings I see on ARM randconfigs in this file, and I think it makes sense to keep it as a separate patch, as these are really distinct problems even thought the symptom is the same. Please apply both. diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index 366cf77953b5..58f3ba709ade 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -142,7 +142,9 @@ #endif #ifndef map_bankwidth +#ifdef CONFIG_MTD #warning "No CONFIG_MTD_MAP_BANK_WIDTH_xx selected. No NOR chip support can work" +#endif static inline int map_bankwidth(void *map) { BUG();