From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Brian Norris" <computersforpeace@gmail.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Cai Huoqing" <caihuoqing@baidu.com>,
"Colin Ian King" <colin.king@intel.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:BROADCOM SPECIFIC AMBA DRIVER (BCMA)"
<linux-wireless@vger.kernel.org>,
"open list:BROADCOM STB NAND FLASH DRIVER"
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v2 2/9] mtd: rawnand: brcmnand: Allow SoC to provide I/O operations
Date: Thu, 6 Jan 2022 19:10:12 -0800 [thread overview]
Message-ID: <703aeebe-3413-0e5e-80ca-4c0bcd36e3f5@gmail.com> (raw)
In-Reply-To: <20220107001328.2233896-3-f.fainelli@gmail.com>
On 1/6/2022 4:13 PM, Florian Fainelli wrote:
> Allow a brcmnand_soc instance to provide a custom set of I/O operations
> which we will require when using this driver on a BCMA bus which is not
> directly memory mapped I/O. Update the nand_{read,write}_reg accordingly
> to use the SoC operations if provided.
>
> To minimize the penalty on other SoCs which do support standard MMIO
> accesses, we use a static key which is disabled by default and gets
> enabled if a soc implementation does provide I/O operations.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
[snip]
> init_completion(&ctrl->done);
> init_completion(&ctrl->dma_done);
> init_completion(&ctrl->edu_done);
> @@ -3145,6 +3169,8 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc)
> /* Enable interrupt */
> ctrl->soc->ctlrdy_ack(ctrl->soc);
> ctrl->soc->ctlrdy_set_enabled(ctrl->soc, true);
> + if (brcmnand_soc_has_ops(soc))
> + static_branch_enable(&brcmnand_soc_has_ops_key);
This hunk got mistakenly added with a rebase, I will wait for additional
comments before spinning a new version.
--
Florian
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-01-07 3:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 0:13 [PATCH v2 0/9] BCMA support for brcmnand Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 1/9] mtd: rawnand: brcmnand: Assign soc as early as possible Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 2/9] mtd: rawnand: brcmnand: Allow SoC to provide I/O operations Florian Fainelli
2022-01-07 3:10 ` Florian Fainelli [this message]
2022-01-07 7:22 ` Miquel Raynal
2022-01-07 0:13 ` [PATCH v2 3/9] mtd: rawnand: brcmnand: Avoid pdev in brcmnand_init_cs() Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 4/9] mtd: rawnand: brcmnand: Move OF operations out of brcmnand_init_cs() Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 5/9] mtd: rawnand: brcmnand: Allow working without interrupts Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 6/9] mtd: rawnand: brcmnand: Add platform data structure for BCMA Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 7/9] mtd: rawnand: brcmnand: Allow platform data instantation Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 8/9] mtd: rawnand: brcmnand: BCMA controller uses command shift of 0 Florian Fainelli
2022-01-07 0:13 ` [PATCH v2 9/9] mtd: rawnand: brcmnand: Add BCMA shim Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703aeebe-3413-0e5e-80ca-4c0bcd36e3f5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=caihuoqing@baidu.com \
--cc=colin.king@intel.com \
--cc=computersforpeace@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).