TC58FVT160 question

TC58FVT160 question

[Der Herr Hofrat]

HI !

 as I can find the TC58FVT160 chip (a 2MB - 16*1024 chip) in amd_flash.c 
 cfi_jedec.c and jedec_probe.c I'm kind of confused at what driver I 
 actually should be configuring for this chip.

 any hint apreaciated.

thx !
hofrat

Re: TC58FVT160 question

[David Woodhouse]

der.herr@hofr.at said:
> 
>  as I can find the TC58FVT160 chip (a 2MB - 16*1024 chip) in
> amd_flash.c cfi_jedec.c and jedec_probe.c I'm kind of confused at
> what driver I actually should be configuring for this chip. 

Er, cfi_jedec.c doesn't actually exist any more. I assume you mean jedec.c?
You should be using the new jedec_probe.c

CONFIG_MTD_JEDECPROBE=y
CONFIG_MTD_CFI_ADV_OPTIONS=n
CONFIG_MTD_CFI_AMDSTD=y
CONFIG_MTD_OBSOLETE_CHIPS=n (which stops it from asking you about 
the CONFIG_MTD_AMDSTD and CONFIG_MTD_JEDEC options).



--
dwmw2

RE: TC58FVT160 question

[Jonas Holmberg]

The patch you gave me for mtdram was pretty useful. Do you want to commit it?

(I added "+ to" compared to your version so use the patch below if you commit)

/Jonas



 static int ram_write(struct mtd_info *mtd, loff_t to, size_t len,
              size_t *retlen, const u_char *buf)
 {
+  size_t c;
+  unsigned char *storage = (char *)mtd->priv + to;
+
   DEBUG(MTD_DEBUG_LEVEL2, "ram_write(pos:%ld, len:%ld)\n", (long)to, (long)len);   if (to + len > mtd->size) {
     DEBUG(MTD_DEBUG_LEVEL1, "ram_write() out of bounds (%ld > %ld)\n", (long)(to + len), (long)mtd->size);
     return -EINVAL;
   }
 
-  memcpy ((char *)mtd->priv + to, buf, len);
+  for (c = 0; c < len; c++) {
+    if ((storage[c] & buf[c]) != buf[c]) {
+      /* We're trying to set bits which weren't set before */
+      printk(KERN_WARNING "mtdram write at 0x%08x tried to set bits "
+             "(from %02x to %02x)\n", to + c, storage[c], buf[c]);
+      *retlen = c;
+      return -EIO;
+    }
+    storage[c] &= buf[c];
+  }
 
   *retlen=len;
   return 0;