Re: [PATCH 1/2] mkfs.ubifs: UBI I/O Library

[Corentin Chary <corentin.chary@gmail.com>]

I didn't think of calling make here.
Thanks

On 5/8/09, Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Fri, May 8, 2009 at 15:41, Corentin Chary wrote:
>> On Fri, May 8, 2009 at 8:58 PM, Mike Frysinger wrote:
>>> On Fri, May 8, 2009 at 10:59, Corentin Chary wrote:
>>>> I'll see what I can do to use libubi the way I want.
>>>> The problem of using libubi in mkfs is not the includes (we can copy
>>>> the headers in /include or add -I../ubi-utils/include).
>>>
>>> why do you need to copy any files ?
>>>
>>>> The main problem is that ubi-utils/Makefile make a libubi.a but
>>>> mkfs.ubifs/Makefile have no way to use it
>>>
>>> what's wrong with adding -lubi and a -L path ?
>>
>> It'll work only if libubi is already built. You can fix that in the
>> root Makefile, but
>> - parallel builds may not work (make -j)
>
> a simple dependency is easy
>
>> - "cd mkfs.ubifs && make" won't work (using only the mkfs.ubifs Makefile)
>
> if the .a file is added to the dependency list, then it's easy to have
> a normal recursive target:
> ........./libubi.a:
>     $(MAKE) -C $(dir $@)
> -mike
>


-- 
Corentin Chary
http://xf.iksaif.net