From: "Rafał Miłecki" <zajec5@gmail.com>
To: Ansuel Smith <ansuelsmth@gmail.com>, Rob Herring <robh@kernel.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible
Date: Fri, 12 Mar 2021 07:15:22 +0100 [thread overview]
Message-ID: <734a5493-5d79-1b51-1f17-ad9f35cc50ca@gmail.com> (raw)
In-Reply-To: <YEn18b9m5mHX8eO7@Ansuel-xps.localdomain>
On 11.03.2021 11:50, Ansuel Smith wrote:
> On Thu, Mar 11, 2021 at 10:32:21AM -0700, Rob Herring wrote:
>> On Thu, Mar 11, 2021 at 06:12:48AM +0100, Ansuel Smith wrote:
>>> Document nvmem-cells compatible used to treat mtd partitions as a
>>> nvmem provider.
>>>
>>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
>>> ---
>>> .../bindings/mtd/partitions/nvmem-cells.yaml | 99 +++++++++++++++++++
>>> 1 file changed, 99 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>> new file mode 100644
>>> index 000000000000..b53faf87d4e4
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
>>> @@ -0,0 +1,99 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mtd/partitions/nvmem-cells.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Nvmem cells
>>> +
>>> +description: |
>>> + Any partition containing the compatible "nvmem-cells" will register as a
>>> + nvmem provider.
>>> + Each direct subnodes represents a nvmem cell following the nvmem binding.
>>> + Nvmem binding to declare nvmem-cells can be found in:
>>> + Documentation/devicetree/bindings/nvmem/nvmem.yaml
>>> +
>>> +maintainers:
>>> + - Ansuel Smith <ansuelsmth@gmail.com>
>>> +
>>> +allOf:
>>> + - $ref: "../../nvmem/nvmem.yaml#"
>>
>> I'd rather have the 'absolute' path:
>>
>> /schemas/nvmem/nvmem.yaml
>>
>> Otherwise,
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>>
>
> Should I send a v7?
Yes, please, let's make it the right way :)
When sending V7 please:
1. Include above "Reviewed-by" in the "dt-bindings: mtd: Document use of nvmem-cells compatible"
2. Include my "Tested-by" in the "mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells"
Reference:
[PATCH v2 2/3] mtd: core: add nvmem-partitions compatible to parse mtd as nvmem cells
https://patchwork.ozlabs.org/project/linux-mtd/patch/20210216212638.28382-3-ansuelsmth@gmail.com/
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-12 6:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 5:12 [PATCH v5 1/3] mtd: core: add nvmem-cells compatible to parse mtd as nvmem cells Ansuel Smith
2021-03-11 5:12 ` [PATCH v5 2/3] dt-bindings: mtd: Document use of nvmem-cells compatible Ansuel Smith
2021-03-11 16:41 ` Rob Herring
2021-03-11 16:57 ` Rob Herring
2021-03-11 17:32 ` Rob Herring
2021-03-11 10:50 ` Ansuel Smith
2021-03-12 6:15 ` Rafał Miłecki [this message]
2021-03-11 5:12 ` [PATCH v5 3/3] devicetree: nvmem: nvmem: drop $nodename restriction Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734a5493-5d79-1b51-1f17-ad9f35cc50ca@gmail.com \
--to=zajec5@gmail.com \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).