From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [PATCH 3/3] ARM: dts: at91: sama5d2: use sama5d2 compatible
 string for SMC
To: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
 <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>,
 <boris.brezillon@free-electrons.com>, <computersforpeace@gmail.com>
References: <20170711074015.30440-1-ludovic.desroches@microchip.com>
 <20170711074015.30440-4-ludovic.desroches@microchip.com>
 <029b80a8-2d3f-11b4-d4df-55f5fc48c8e7@microchip.com>
 <20170711075829.5rzdrjgao6efiuj2@rfolt0960.corp.atmel.com>
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Message-ID: <73c25b77-856b-b4c3-7e53-8f60c72dbc6e@microchip.com>
Date: Tue, 11 Jul 2017 10:07:00 +0200
MIME-Version: 1.0
In-Reply-To: <20170711075829.5rzdrjgao6efiuj2@rfolt0960.corp.atmel.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On 11/07/2017 at 09:58, Ludovic Desroches wrote:
> On Tue, Jul 11, 2017 at 09:52:58AM +0200, Nicolas Ferre wrote:
>> On 11/07/2017 at 09:40, Ludovic Desroches wrote:
>>> A new compatible string has been introduced for sama5d2 SMC to allow to
>>> manage the registers mapping change.
>>>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
>>> ---
>>>  arch/arm/boot/dts/sama5d2.dtsi | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
>>> index 4fcd5bb219e3..60e69aeacbdb 100644
>>> --- a/arch/arm/boot/dts/sama5d2.dtsi
>>> +++ b/arch/arm/boot/dts/sama5d2.dtsi
>>> @@ -1048,7 +1048,7 @@
>>>  			};
>>>  
>>>  			hsmc: hsmc@f8014000 {
>>> -				compatible = "atmel,sama5d3-smc", "syscon", "simple-mfd";
>>> +				compatible = "atmel,sama5d2-smc", "syscon", "simple-mfd";
>>
>> You'd better use something like:
>>  compatible = "atmel,sama5d2-smc", "atmel,sama5d3-smc", "syscon", "simple-mfd";
> 
> But it's not true, during data interface setup, we will write values in
> the wrong place if we fallback on "atmel,sama5d3-smc".

Yes, I wrote too quickly: sorry for the noise ;-)

Bye,


>> So that this patch is independent from the rest of the series and
>> we can avoid to having to synchronize with mfd or mtd/nand for this part.
>>
>> Regards,
>>
>>>  				reg = <0xf8014000 0x1000>;
>>>  				interrupts = <17 IRQ_TYPE_LEVEL_HIGH 6>;
>>>  				clocks = <&hsmc_clk>;
>>>
>>
>>
>> -- 
>> Nicolas Ferre
> 


-- 
Nicolas Ferre