From: Marek Vasut <marek.vasut@gmail.com>
To: "Cédric Le Goater" <clg@kaod.org>, linux-mtd@lists.infradead.org
Cc: Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH 10/10] mtd: spi-nor: aspeed: optimize read mode
Date: Thu, 6 Apr 2017 21:28:44 +0200 [thread overview]
Message-ID: <7d80fbb3-81d9-3ac0-6bb9-47d2d4cf0855@gmail.com> (raw)
In-Reply-To: <1491497808-25487-11-git-send-email-clg@kaod.org>
On 04/06/2017 06:56 PM, Cédric Le Goater wrote:
> This is only for SPI controllers as U-Boot should have done it already
> for the FMC controller using DMAs.
>
> The algo is based on the one found in the OpenPOWER pflash tool. It
> first reads a golden buffer at low speed and then performs reads with
> different clocks and delay cycles settings to find the fastest
> configuration for the chip.
>
> It can be deactivated at boot time with the kernel parameter :
Something tells me this is likely gonna be pretty flaky and might lead
to unreliable configurations. The hardware manufacturer should be able
to determine the limits of the hardware and those should be put into DT
at manufacturing time IMO.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-04-06 19:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 16:56 [PATCH 00/10] mtd: spi-nor: aspeed: support extensions Cédric Le Goater
2017-04-06 16:56 ` [PATCH 01/10] mtd: spi-nor: aspeed: fix the AST2400 SMC window size Cédric Le Goater
2017-04-06 19:17 ` Marek Vasut
2017-04-11 10:18 ` Cédric Le Goater
2017-04-11 10:42 ` Marek Vasut
2017-04-11 16:10 ` Cédric Le Goater
2017-04-06 16:56 ` [PATCH 02/10] mtd: spi-nor: aspeed: remove dummies from keep mask Cédric Le Goater
2017-04-06 16:56 ` [PATCH 03/10] mtd: spi-nor: aspeed: add DMA support Cédric Le Goater
2017-04-06 19:07 ` Cyrille Pitchen
2017-04-06 19:13 ` Cyrille Pitchen
2017-04-19 14:36 ` Cédric Le Goater
2017-04-06 16:56 ` [PATCH 04/10] mtd: spi-nor: aspeed: add support for SPI dual IO read mode Cédric Le Goater
2017-04-06 19:21 ` Marek Vasut
2017-04-11 8:53 ` Cédric Le Goater
2017-04-11 10:43 ` Marek Vasut
2017-04-06 16:56 ` [PATCH 05/10] mtd: spi-nor: Add support for Macronix mx66l1g45g spi flash Cédric Le Goater
2017-04-06 19:21 ` Marek Vasut
2017-04-06 16:56 ` [PATCH 06/10] mtd: spi-nor: add SPI_NOR_DUAL_READ to some flash devices Cédric Le Goater
2017-04-06 19:22 ` Marek Vasut
2017-04-11 8:15 ` Cédric Le Goater
2017-04-06 16:56 ` [PATCH 07/10] mtd: spi-nor: aspeed: configure chip window on AHB bus Cédric Le Goater
2017-04-06 19:25 ` Marek Vasut
2017-04-11 10:20 ` Cédric Le Goater
2017-04-11 10:44 ` Marek Vasut
2017-04-06 16:56 ` [PATCH 08/10] mtd: spi-nor: aspeed: use command mode for reads Cédric Le Goater
2017-04-06 16:56 ` [PATCH 09/10] mtd: spi-nor: aspeed: link controller with the ahb clock Cédric Le Goater
2017-04-06 16:56 ` [PATCH 10/10] mtd: spi-nor: aspeed: optimize read mode Cédric Le Goater
2017-04-06 19:28 ` Marek Vasut [this message]
2017-04-11 8:13 ` Cédric Le Goater
2017-04-11 8:23 ` Benjamin Herrenschmidt
2017-04-14 16:18 ` Marek Vasut
2017-04-14 21:40 ` Benjamin Herrenschmidt
2017-04-14 21:51 ` Marek Vasut
2017-04-14 22:11 ` Benjamin Herrenschmidt
2017-04-14 22:25 ` Marek Vasut
2017-04-14 22:42 ` Benjamin Herrenschmidt
2017-04-16 18:46 ` Marek Vasut
2017-04-18 15:46 ` Cédric Le Goater
2017-04-18 16:51 ` Marek Vasut
2017-04-18 22:41 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d80fbb3-81d9-3ac0-6bb9-47d2d4cf0855@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=clg@kaod.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=joel@jms.id.au \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox