From: liaoweixiong <liaoweixiong@allwinnertech.com>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Greg KH <gregkh@linuxfoundation.org>,
Brian Norris <computersforpeace@gmail.com>,
Chuanhong Guo <gch981213@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips
Date: Tue, 25 Jun 2019 19:56:10 +0800 [thread overview]
Message-ID: <814a343e-e4c4-3ef2-29e2-d6c56f3d5bbb@allwinnertech.com> (raw)
In-Reply-To: <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de>
Oh, i am sorry that i had misunderstanded your letter.
Thank you for your document and guidance.
On 2019/6/25 PM 3:04, Schrempf Frieder wrote:
> Hi liaoweixiong,
>
> On 25.06.19 05:08, Greg KH wrote:
>> On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote:
>>> In case of the last page containing bitflips (ret > 0),
>>> spinand_mtd_read() will return that number of bitflips for the last
>>> page. But to me it looks like it should instead return max_bitflips like
>>> it does when the last page read returns with 0.
>>>
>>> Signed-off-by: liaoweixiong <liaoweixiong@allwinnertech.com>
>>> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
>>> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
>>> ---
>>> drivers/mtd/nand/spi/core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> <formletter>
>>
>> This is not the correct way to submit patches for inclusion in the
>> stable kernel tree. Please read:
>> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
>> for how to do this properly.
>>
>> </formletter>
>
> FYI, you should not send the patch to stable@vger.kernel.org, but
> instead, as I said in my other reply, add the tag "Cc:
> stable@vger.kernel.org". See "Option 1" in the document Greg referred to.
>
> Thanks,
> Frieder
>
--
liaoweixiong
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-25 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 1:02 [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips liaoweixiong
2019-06-25 3:08 ` Greg KH
2019-06-25 7:04 ` Schrempf Frieder
2019-06-25 11:56 ` liaoweixiong [this message]
2019-06-25 12:04 ` Schrempf Frieder
2019-06-27 17:06 ` Miquel Raynal
2019-06-27 18:17 ` Miquel Raynal
2019-06-28 3:51 ` liaoweixiong
-- strict thread matches above, loose matches on Subject: below --
2019-06-25 12:03 liaoweixiong
2019-06-24 12:15 liaoweixiong
2019-06-24 14:47 ` Schrempf Frieder
2019-06-25 1:00 ` liaoweixiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=814a343e-e4c4-3ef2-29e2-d6c56f3d5bbb@allwinnertech.com \
--to=liaoweixiong@allwinnertech.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@kontron.de \
--cc=gch981213@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox