From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH v2] mtd: spi-nor: Use DMA-safe buffer for JEDEC ID in spi_nor_read_id()
Date: Mon, 17 Sep 2018 15:51:24 +0300 [thread overview]
Message-ID: <870a6721-620c-a73c-82f9-014fdb02cd6c@linux.intel.com> (raw)
In-Reply-To: <20180917142857.16be0331@bbrezillon>
On 09/17/2018 03:28 PM, Boris Brezillon wrote:
> On Mon, 17 Sep 2018 12:04:43 +0300
> Jarkko Nikula <jarkko.nikula@linux.intel.com> wrote:
>
>> On 09/17/2018 11:46 AM, Boris Brezillon wrote:
>>> On Mon, 17 Sep 2018 11:41:31 +0300
>>> Jarkko Nikula <jarkko.nikula@linux.intel.com> wrote:
>>>
>>>> On 09/17/2018 11:28 AM, Boris Brezillon wrote:
>>>>>
>>>>> Hm, I just had a look at all ->read/write_reg() call sites and it seems
>>>>> we have the same problem in other places. Maybe it's just better to fix
>>>>> the problem in m25p80 ->read/write_reg() implems for now
>
> Do you plan to send a new fix doing that, or should I? I'd really like
> to have the fix queued to mtd/master early this week, so that it
> spends a bit of time in -next.
>
I guess better if you could as I haven't started anything yet. I'm not
so familiar with the code to see what would be best way to fix,
reverting m25p80_read_reg/m25p80_write_reg back to spi_write(), the
whole commit or do some kmemdup() there.
--
Jarkko
next prev parent reply other threads:[~2018-09-17 12:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 8:10 [PATCH v2] mtd: spi-nor: Use DMA-safe buffer for JEDEC ID in spi_nor_read_id() Jarkko Nikula
2018-09-17 8:18 ` Boris Brezillon
2018-09-17 8:28 ` Boris Brezillon
2018-09-17 8:41 ` Jarkko Nikula
2018-09-17 8:46 ` Boris Brezillon
2018-09-17 9:04 ` Jarkko Nikula
2018-09-17 12:28 ` Boris Brezillon
2018-09-17 12:51 ` Jarkko Nikula [this message]
2018-09-17 12:59 ` Boris Brezillon
2018-09-17 13:37 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=870a6721-620c-a73c-82f9-014fdb02cd6c@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).