[PATCH] mtd: spinand: Improve spinand_info macros style

[PATCH] mtd: spinand: Improve spinand_info macros style

[Miquel Raynal]

Let's assume all these macros should not have a trailing coma, this way
the caller can use a more formal and usual C writing style, as reflected
in the Macronix driver.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/mtd/nand/spi/macronix.c | 10 +++++-----
 include/linux/mtd/spinand.h     |  8 ++++----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
index c9abac46ed05..1ef08ad850a2 100644
--- a/drivers/mtd/nand/spi/macronix.c
+++ b/drivers/mtd/nand/spi/macronix.c
@@ -187,7 +187,7 @@ static const struct spinand_info macronix_spinand_table[] = {
 		     SPINAND_HAS_QE_BIT,
 		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
 				     macronix_ecc_get_status),
-		     SPINAND_CONT_READ(macronix_set_cont_read)
+		     SPINAND_CONT_READ(macronix_set_cont_read),
 		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
 					macronix_set_read_retry)),
 	SPINAND_INFO("MX35LF4GE4AD",
@@ -200,7 +200,7 @@ static const struct spinand_info macronix_spinand_table[] = {
 		     SPINAND_HAS_QE_BIT,
 		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
 				     macronix_ecc_get_status),
-		     SPINAND_CONT_READ(macronix_set_cont_read)
+		     SPINAND_CONT_READ(macronix_set_cont_read),
 		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
 					macronix_set_read_retry)),
 	SPINAND_INFO("MX35LF1G24AD",
@@ -328,7 +328,7 @@ static const struct spinand_info macronix_spinand_table[] = {
 		     SPINAND_HAS_QE_BIT,
 		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
 				     macronix_ecc_get_status),
-		     SPINAND_CONT_READ(macronix_set_cont_read)
+		     SPINAND_CONT_READ(macronix_set_cont_read),
 		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
 					macronix_set_read_retry)),
 	SPINAND_INFO("MX35UF2G14AC",
@@ -378,7 +378,7 @@ static const struct spinand_info macronix_spinand_table[] = {
 		     SPINAND_HAS_QE_BIT,
 		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
 				     macronix_ecc_get_status),
-		     SPINAND_CONT_READ(macronix_set_cont_read)
+		     SPINAND_CONT_READ(macronix_set_cont_read),
 		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
 					macronix_set_read_retry)),
 	SPINAND_INFO("MX35UF2GE4AC",
@@ -424,7 +424,7 @@ static const struct spinand_info macronix_spinand_table[] = {
 		     SPINAND_HAS_QE_BIT,
 		     SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
 				     macronix_ecc_get_status),
-		     SPINAND_CONT_READ(macronix_set_cont_read)
+		     SPINAND_CONT_READ(macronix_set_cont_read),
 		     SPINAND_READ_RETRY(MACRONIX_NUM_READ_RETRY_MODES,
 					macronix_set_read_retry)),
 	SPINAND_INFO("MX35UF1GE4AC",
diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h
index 5837a09ab9d8..1e748958dad4 100644
--- a/include/linux/mtd/spinand.h
+++ b/include/linux/mtd/spinand.h
@@ -502,10 +502,10 @@ struct spinand_info {
 	}
 
 #define SPINAND_SELECT_TARGET(__func)					\
-	.select_target = __func,
+	.select_target = __func
 
 #define SPINAND_CONT_READ(__set_cont_read)				\
-	.set_cont_read = __set_cont_read,
+	.set_cont_read = __set_cont_read
 
 #define SPINAND_FACT_OTP_INFO(__npages, __start_page, __ops)		\
 	.fact_otp = {							\
@@ -526,8 +526,8 @@ struct spinand_info {
 	}
 
 #define SPINAND_READ_RETRY(__read_retries, __set_read_retry)		\
-	.read_retries = __read_retries,				\
-	.set_read_retry = __set_read_retry,
+	.read_retries = __read_retries,					\
+	.set_read_retry = __set_read_retry
 
 #define SPINAND_INFO(__model, __id, __memorg, __eccreq, __op_variants,	\
 		     __flags, ...)					\
-- 
2.48.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spinand: Improve spinand_info macros style

[Pratyush Yadav]

On Tue, Mar 04 2025, Miquel Raynal wrote:

> Let's assume all these macros should not have a trailing coma, this way

s/coma/comma

Acked-by: Pratyush Yadav <pratyush@kernel.org>

> the caller can use a more formal and usual C writing style, as reflected
> in the Macronix driver.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spinand: Improve spinand_info macros style

[Miquel Raynal]

Hi Pratyush,

On 04/03/2025 at 12:34:33 GMT, Pratyush Yadav <pratyush@kernel.org> wrote:

> On Tue, Mar 04 2025, Miquel Raynal wrote:
>
>> Let's assume all these macros should not have a trailing coma, this way
>
> s/coma/comma

I think I never spelled it correctly, but as the word 'coma' also exists
(the medical term) it never got underlined by spellers.

Thanks for the feedback. I'll see maybe I'll fix it while applying.

Cheers,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spinand: Improve spinand_info macros style

[Tudor Ambarus]

On 3/4/25 1:54 PM, Miquel Raynal wrote:
> Hi Pratyush,
> 
> On 04/03/2025 at 12:34:33 GMT, Pratyush Yadav <pratyush@kernel.org> wrote:
> 
>> On Tue, Mar 04 2025, Miquel Raynal wrote:
>>
>>> Let's assume all these macros should not have a trailing coma, this way
>>
>> s/coma/comma
> 
> I think I never spelled it correctly, but as the word 'coma' also exists
> (the medical term) it never got underlined by spellers.

:)

> 
> Thanks for the feedback. I'll see maybe I'll fix it while applying.
> 

It's always good to address review feedback, even on typos. Otherwise it
may encourage reviewers to not point out typos anymore.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spinand: Improve spinand_info macros style

[Miquel Raynal]

Hello Tudor,

>>>> Let's assume all these macros should not have a trailing coma, this way
>>>
>>> s/coma/comma

...

>> Thanks for the feedback. I'll see maybe I'll fix it while applying.
>
> It's always good to address review feedback, even on typos. Otherwise it
> may encourage reviewers to not point out typos anymore.

Sorry for not being clear, I do not intend to leave the typo. I might
however fix it while applying, as no code is anyway impacted in this
case.

Cheers,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

Re: [PATCH] mtd: spinand: Improve spinand_info macros style

[Miquel Raynal]

On Tue, 04 Mar 2025 12:05:39 +0100, Miquel Raynal wrote:
> Let's assume all these macros should not have a trailing coma, this way
> the caller can use a more formal and usual C writing style, as reflected
> in the Macronix driver.
> 
> 

Applied to nand/next after fixing the typo reported by Pratyush, thanks!

[1/1] mtd: spinand: Improve spinand_info macros style
      commit: b28f47ac3ddd072cce0e447ace89e2b4d6932c66

Kind regards,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/