Re: [PATCH 03/30] mtd: spi-nor: winbond: Stop filling the .name entry

[Miquel Raynal <miquel.raynal@bootlin.com>]

On 06/07/2026 at 15:59:53 +02, "Michael Walle" <mwalle@kernel.org> wrote:

> On Fri May 29, 2026 at 5:22 PM CEST, Miquel Raynal wrote:
>> This is a legacy field, it is often incorrectly filled and will soon
>> become very incorrect due to IDs being reused.
>
> And I thought winbond is doing better... So if you have a contact
> there, please suggest they are putting a table with a unique
> identifier per chip there. So we can use that to do fixups.

Yes, this is something that has been raised, I can confirm. We found a
way through the SFDP data to reliably identify which chip it is since
the SFDP version has been reliably updated over time (see the RV and PW
addition patches).

>> Replace the names with a comment above the entry with the newly instated
>> naming scheme to indicate what chips are covered by each entry.
>
> This is exported via sysfs, so this could be a regression.
>
> Not sure..

Yes, but the names are totally wrong. And become even wronger with the
addition of the RV, PW, etc families. I was already asked to not put a
name on the new additions, I believe we should drop those fields, they
are very misleading. So what is your final position? Pratyush any
feedback? I can keep the old names, but, well, you know my position,
they are wrong and old.

Thanks for the feedback by the way!
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/