Re: [PATCH v2] mtd: core: always verify OOB offset in mtd_check_oob_ops()

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Santhosh Kumar K <s-k6@ti.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Gabor Juhos <j4g8y7@gmail.com>, <linux-mtd@lists.infradead.org>,
	 <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
	 Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH v2] mtd: core: always verify OOB offset in mtd_check_oob_ops()
Date: Thu, 11 Sep 2025 10:00:39 +0200	[thread overview]
Message-ID: <87348tbeqg.fsf@bootlin.com> (raw)
In-Reply-To: <454e092d-5b75-4758-a0e9-dfbb7bf271d7@ti.com> (Santhosh Kumar K.'s message of "Thu, 11 Sep 2025 11:52:27 +0530")

Hello,

On 11/09/2025 at 11:52:27 +0530, Santhosh Kumar K <s-k6@ti.com> wrote:

> Hello,
>
> On 05/09/25 20:25, Miquel Raynal wrote:
>> On Mon, 01 Sep 2025 16:24:35 +0200, Gabor Juhos wrote:
>>> Using an OOB offset past end of the available OOB data is invalid,
>>> irregardless of whether the 'ooblen' is set in the ops or not. Move
>>> the relevant check out from the if statement to always verify that.
>>>
>>> The 'oobtest' module executes four tests to verify how reading/writing
>>> OOB data past end of the devices is handled. It expects errors in case
>>> of these tests, but this expectation fails in the last two tests on
>>> MTD devices, which have no OOB bytes available.
>>>
>>> [...]
>> Applied to mtd/next, thanks!
>> [1/1] mtd: core: always verify OOB offset in mtd_check_oob_ops()
>>        commit: bf7d0543b2602be5cb450d8ec5a8710787806f88
>
> I'm seeing a failure in SPI NOR flashes due to this patch:
> (Tested on AM62x SK with S28HS512T OSPI NOR flash)

Gabor, can you check what happens with mtdblock? Otherwise this will
need to be reverted.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/