From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp05.smtpout.orange.fr ([80.12.242.127] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eQzLw-0002Qm-El for linux-mtd@lists.infradead.org; Mon, 18 Dec 2017 17:37:26 +0000 From: Robert Jarzmik To: Boris Brezillon (by way of Boris Brezillon ) Cc: Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Ezequiel Garcia , Sean =?utf-8?Q?Nyekj=C3=A6r?= , Greg Cook , Miquel RAYNAL , stable@kernel.vger.org Subject: Re: [PATCH] mtd: nand: pxa3xx: Fix READOOB implementation References: <20171218103245.22516-1-boris.brezillon@free-electrons.com> Date: Mon, 18 Dec 2017 18:37:08 +0100 In-Reply-To: <20171218103245.22516-1-boris.brezillon@free-electrons.com> (Boris Brezillon's message of "Mon, 18 Dec 2017 11:32:45 +0100") Message-ID: <873748djjv.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Boris Brezillon (by way of Boris Brezillon ) writes: > In the current driver, OOB bytes are accessed in raw mode, and when a > page access is done with NDCR_SPARE_EN set and NDCR_ECC_EN cleared, the > driver must read the whole spare area (64 bytes in case of a 2k page, > 16 bytes for a 512 page). The driver was only reading the free OOB > bytes, which was leaving some unread data in the FIFO and was somehow > leading to a timeout. That's a very good catch. Acked-by: Robert Jarzmik Cheers. -- Robert