From: Ferenc Wagner <wferi@niif.hu>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: linux-fsdevel@vger.kernel.org,
Phillip Lougher <phillip.lougher@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-embedded@vger.kernel.org
Subject: Re: [PATCH 2/3] squashfs: gather everything block device specific into block.c
Date: Tue, 30 Mar 2010 18:50:18 +0200 [thread overview]
Message-ID: <8739zhu52t.fsf@tac.ki.iif.hu> (raw)
In-Reply-To: <1269955969-26123-3-git-send-email-wferi@niif.hu> (Ferenc Wagner's message of "Tue, 30 Mar 2010 15:32:48 +0200")
---
I lost this free somehow. Does squashfs_put_super() need protection
from multiple invocation? If not, this kfree could be removed from
there, and the condition from both places.
fs/squashfs/backend.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/squashfs/backend.c b/fs/squashfs/backend.c
index a6136ca..0ae37ab 100644
--- a/fs/squashfs/backend.c
+++ b/fs/squashfs/backend.c
@@ -24,6 +24,10 @@ int squashfs_find_backend(struct file_system_type *fs_type, int flags,
void squashfs_kill_super(struct super_block *sb)
{
+ if (sb->s_fs_info) {
+ kfree(sb->s_fs_info);
+ sb->s_fs_info = NULL;
+ }
#ifdef CONFIG_BLOCK
if (sb->s_bdev) {
kill_block_super(sb);
--
1.6.5
next prev parent reply other threads:[~2010-03-30 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 13:38 RFC: direct MTD support for SquashFS Ferenc Wagner
2010-03-16 14:26 ` Peter Korsgaard
2010-03-16 19:18 ` Vitaly Wool
2010-03-18 16:38 ` Ferenc Wagner
2010-03-18 21:40 ` Phillip Lougher
2010-03-18 22:52 ` Ferenc Wagner
2010-03-19 1:05 ` Ferenc Wagner
2010-03-19 7:30 ` Phillip Lougher
2010-03-19 14:12 ` Ferenc Wagner
2010-03-23 11:34 ` Ferenc Wagner
2010-03-23 20:45 ` Ferenc Wagner
2010-03-23 20:47 ` Ferenc Wagner
2010-03-24 5:23 ` Phillip Lougher
2010-03-24 6:35 ` Peter Korsgaard
2010-03-24 11:28 ` Ferenc Wagner
2010-03-24 11:35 ` Peter Korsgaard
2010-03-24 13:48 ` Ferenc Wagner
[not found] ` <1269955969-26123-3-git-send-email-wferi@niif.hu>
2010-03-30 16:50 ` Ferenc Wagner [this message]
[not found] ` <1269955969-26123-1-git-send-email-wferi@niif.hu>
2010-03-31 6:35 ` [PATCH 0/3] " Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739zhu52t.fsf@tac.ki.iif.hu \
--to=wferi@niif.hu \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=phillip.lougher@gmail.com \
--cc=phillip@lougher.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox