Re: [PATCH v3 7/7] mtd: rawnand: loongson: Add Loongson-2K1000 NAND controller support

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Binbin Zhou <zhoubb.aaron@gmail.com>,
	 Huacai Chen <chenhuacai@loongson.cn>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Keguang Zhang <keguang.zhang@gmail.com>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Huacai Chen <chenhuacai@kernel.org>,
	 Xuerui Wang <kernel@xen0n.name>,
	loongarch@lists.linux.dev,  devicetree@vger.kernel.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v3 7/7] mtd: rawnand: loongson: Add Loongson-2K1000 NAND controller support
Date: Sun, 24 Aug 2025 17:40:02 +0200	[thread overview]
Message-ID: <875xeclodp.fsf@bootlin.com> (raw)
In-Reply-To: <f01986dcb9f16450bd7f38c8fd663df686e6d145.1755757841.git.zhoubinbin@loongson.cn> (Binbin Zhou's message of "Thu, 21 Aug 2025 14:39:21 +0800")

On 21/08/2025 at 14:39:21 +08, Binbin Zhou <zhoubinbin@loongson.cn> wrote:

> The Loongson-2K1000 NAND controller is also similar to the Loongson-1C.
>
> It supports a maximum capacity of 16GB FLASH per chip with a maximum
> page size of 8KB, and it supports up to 4 chip selects and 4 RDY
> signals.
>
> The key difference from the Loongson-2K0500 is that it requires explicit
> configuration of the DMA control route. Typically, it is configured as
> APBDMA0.
>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
>  .../mtd/nand/raw/loongson-nand-controller.c   | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/loongson-nand-controller.c b/drivers/mtd/nand/raw/loongson-nand-controller.c
> index 7b331d0ca2f0..6610c239f721 100644
> --- a/drivers/mtd/nand/raw/loongson-nand-controller.c
> +++ b/drivers/mtd/nand/raw/loongson-nand-controller.c
> @@ -73,9 +73,18 @@
>  #define LOONGSON_NAND_READ_ID_TIMEOUT_US	5000
>  
>  #define LOONGSON_NAND_64BIT_DMA		BIT(0)
> +#define LOONGSON_NAND_DMA_CONFIG	BIT(1)

You're reusing this flags member, so it's fine, please ignore the
previous comment (except the style issue).

...

> +	regs = devm_platform_ioremap_resource(pdev, 2);

Would it be clearer to get the resource by name? (not a strong request)

Thanks
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/