public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mtd: spi-nor: explicitly include <linux/mod_devicetable.h>
Date: Fri, 07 Mar 2025 09:22:37 +0100	[thread overview]
Message-ID: <875xkltfle.fsf@bootlin.com> (raw)
In-Reply-To: <20250307-spi-nor-headers-cleanup-v1-2-c186a9511c1e@linaro.org> (Tudor Ambarus's message of "Fri, 07 Mar 2025 09:09:06 +0200")

Hello Tudor,

On 07/03/2025 at 09:09:06 +02, Tudor Ambarus <tudor.ambarus@linaro.org> wrote:

> The core driver is using 'struct of_device_id' and relies on implicit
> inclusion of <linux/mod_devicetable.h>, which comes from
> <linux/of_platform.h>.

It is actually included from of.h now (since patch 1) and I wonder
whether there is a need for it to be included explicitly. As a user it
feels like "of.h" should already include whatever is needed for us (and
it's the case). Looking at the numbers, about 25% of the drivers do
include it explicitly. But either ways I'm fine.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2025-03-07  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07  7:09 [PATCH 0/3] mtd: spi-nor: headers cleanup Tudor Ambarus
2025-03-07  7:09 ` [PATCH 1/3] mtd: spi-nor: explicitly include <linux/of.h> Tudor Ambarus
2025-03-07  8:15   ` Miquel Raynal
2025-03-07  7:09 ` [PATCH 2/3] mtd: spi-nor: explicitly include <linux/mod_devicetable.h> Tudor Ambarus
2025-03-07  8:22   ` Miquel Raynal [this message]
2025-03-07 12:21     ` Tudor Ambarus
2025-03-07  7:09 ` [PATCH 3/3] mtd: spi-nor: drop unused <linux/of_platform.h> Tudor Ambarus
2025-03-07  8:23   ` Miquel Raynal
2025-03-18  6:04 ` (subset)Re: [PATCH 0/3] mtd: spi-nor: headers cleanup Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xkltfle.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox