public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] mtd: parsers: extend Qcom SMEM parser to SPI flash
Date: Tue, 23 Feb 2021 14:16:29 +0200	[thread overview]
Message-ID: <875z2jj7xe.fsf@tarshish> (raw)
In-Reply-To: <20210223120717.GA9724@work>

Hi Manivannan,

On Tue, Feb 23 2021, Manivannan Sadhasivam wrote:
> On Tue, Feb 23, 2021 at 01:47:04PM +0200, Baruch Siach wrote:
>> The Qcom MIBIB partition might be stored on SPI flash devices, and the
>> parser works in this case just as well:
>
> Nice!
>
>> [    1.404229] spi_qup 78b5000.spi: IN:block:16, fifo:64, OUT:block:16, fifo:64
>> [    1.408078] spi-nor spi0.0: found mx25u6435f, expected n25q128a11
>> [    1.415016] spi-nor spi0.0: mx25u6435f (8192 Kbytes)
>> [    1.420756] 12 qcomsmem partitions found on MTD device spi0.0
>> [    1.425739] Creating 12 MTD partitions on "spi0.0":
>> [    1.431381] 0x000000000000-0x00000000c000 : "0:sbl1"
>> [    1.437058] 0x00000000c000-0x00000000d000 : "0:mibib"
>> [    1.442143] 0x00000000d000-0x000000027000 : "0:qsee"
>> [    1.447057] 0x000000027000-0x000000028000 : "0:devcfg"
>> [    1.452088] 0x000000028000-0x00000002a000 : "0:rpm"
>> [    1.457065] 0x00000002a000-0x00000002b000 : "0:cdt"
>> [    1.461832] 0x00000002b000-0x00000002c000 : "0:appsblenv"
>> [    1.466736] 0x00000002c000-0x000000036000 : "0:appsbl"
>> [    1.472248] 0x000000036000-0x00000003a000 : "0:art"
>> [    1.477297] 0x00000003a000-0x00000003e000 : "config"
>> [    1.482047] 0x00000003e000-0x00000004e000 : "data"
>> [    1.487257] 0x00000004e000-0x000000200000 : "0:hlos"
>> 
>> Remove dependency on MTD_NAND_QCOM. Update the Kconfig prompt and help
>> text accordingly.
>> 
>> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>>  drivers/mtd/parsers/Kconfig | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
>> index d90c30229052..96d5716db544 100644
>> --- a/drivers/mtd/parsers/Kconfig
>> +++ b/drivers/mtd/parsers/Kconfig
>> @@ -162,9 +162,8 @@ config MTD_REDBOOT_PARTS_READONLY
>>  endif # MTD_REDBOOT_PARTS
>>  
>>  config MTD_QCOMSMEM_PARTS
>> -	tristate "Qualcomm SMEM NAND flash partition parser"
>> -	depends on MTD_NAND_QCOM || COMPILE_TEST
>
> Can we keep COMPILE_TEST below?

The code will not build without QCOM_SMEM, I believe.

Thanks for your review,
baruch

> With that,
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> Thanks,
> Mani
>
>> +	tristate "Qualcomm SMEM flash partition parser"
>>  	depends on QCOM_SMEM
>>  	help
>>  	  This provides support for parsing partitions from Shared Memory (SMEM)
>> -	  for NAND flash on Qualcomm platforms.
>> +	  for NAND and SPI flash on Qualcomm platforms.
>> -- 
>> 2.30.0

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-02-23 12:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 11:47 [PATCH] mtd: parsers: extend Qcom SMEM parser to SPI flash Baruch Siach
2021-02-23 12:07 ` Manivannan Sadhasivam
2021-02-23 12:16   ` Baruch Siach [this message]
2021-02-23 13:06     ` Manivannan Sadhasivam
2021-03-02 17:13 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z2jj7xe.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=linux-mtd@lists.infradead.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox