From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp09.smtpout.orange.fr ([80.12.242.131] helo=smtp.smtpout.orange.fr) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fLue6-0007Ly-8v for linux-mtd@lists.infradead.org; Thu, 24 May 2018 18:07:29 +0000 From: Robert Jarzmik To: Miquel Raynal , Daniel Mack , Haojian Zhuang , Ezequiel Garcia , Boris Brezillon , David Woodhouse , Brian Norris Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need References: <20180524070703.11901-1-robert.jarzmik@free.fr> <20180524070703.11901-6-robert.jarzmik@free.fr> <20180524113006.3d5f393e@xps13> Date: Thu, 24 May 2018 20:07:11 +0200 In-Reply-To: <20180524113006.3d5f393e@xps13> (Miquel Raynal's message of "Thu, 24 May 2018 11:30:06 +0200") Message-ID: <87603dx700.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Miquel Raynal writes: > Hi Robert, Actually, a last time error slipped in this patch here (I'm really doing poorly on the copy paste side): + nfc->dma_chan = dma_request_slave_channel(&nfc->dev, "data"); This should rather be : + nfc->dma_chan = dma_request_slave_channel(nfc->dev, "data"); Would you grant your ack for the next iteration with this change folded in ? Cheers. -- Robert