From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <linux-mtd@lists.infradead.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: Re: [PATCH] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd'
Date: Sat, 05 Mar 2016 09:34:14 +0100 [thread overview]
Message-ID: <877fhhwcft.fsf@belgarion.home> (raw)
In-Reply-To: <1457147553-71596-1-git-send-email-computersforpeace@gmail.com> (Brian Norris's message of "Fri, 4 Mar 2016 19:12:33 -0800")
Brian Norris <computersforpeace@gmail.com> writes:
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Hi Brian,
> @@ -1812,7 +1811,6 @@ static int alloc_nand_resource(struct platform_device *pdev)
> ret = -ENXIO;
> goto fail_disable_clk;
> }
> - info->drcmr_cmd = r->start;
> }
If you kill this field, why not kill also this block just above ?
r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
if (r == NULL) {
dev_err(&pdev->dev,
"no resource defined for cmd DMA\n");
ret = -ENXIO;
goto fail_disable_clk;
}
Cheers.
--
Robert
next prev parent reply other threads:[~2016-03-05 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 3:12 [PATCH] mtd: nand: pxa3xx_nand: kill unused field 'drcmr_cmd' Brian Norris
2016-03-05 8:34 ` Robert Jarzmik [this message]
2016-03-07 18:37 ` [PATCH v2] " Brian Norris
2016-03-07 19:35 ` Robert Jarzmik
2016-03-07 20:49 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fhhwcft.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox