From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: <linux-mtd@lists.infradead.org>,
Antoine Tenart <antoine.tenart@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH 4/6] mtd: pxa3xx_nand: Remove redundant NAND sensing
Date: Wed, 04 Nov 2015 22:05:30 +0100 [thread overview]
Message-ID: <878u6dbhlx.fsf@belgarion.home> (raw)
In-Reply-To: <1446653626-14802-5-git-send-email-ezequiel@vanguardiasur.com.ar> (Ezequiel Garcia's message of "Wed, 4 Nov 2015 13:13:44 -0300")
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> Currently, the driver is trying to detect the presence of a chip
> by issuing a RESET command before nand_scan_ident. This seems completely
> redundant, and is also a layering violation as nand_scan_ident is in charge
> of device detection.
>
> This commit removes the RESET command use, and moves the initial
> timing configuration to pxa3xx_nand_config_ident.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
That one looks good to me. I have not taken the time to apply it to see the
overall change, but from a first sight it's ok.
Cheers.
--
Robert
next prev parent reply other threads:[~2015-11-04 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 16:13 [PATCH 0/6] pxa3xx_nand: Assorted changes Ezequiel Garcia
2015-11-04 16:13 ` [PATCH 1/6] mtd: pxa3xx_nand: Increase the initial chunk size Ezequiel Garcia
2015-11-04 20:15 ` Robert Jarzmik
2015-11-04 16:13 ` [PATCH 2/6] mtd: pxa3xx_nand: Fix initial controller configuration Ezequiel Garcia
2015-11-04 16:13 ` [PATCH 3/6] nand: pxa3xx: Simplify pxa3xx_nand_scan Ezequiel Garcia
2015-11-04 20:56 ` Robert Jarzmik
2015-11-04 21:08 ` Ezequiel Garcia
2015-11-04 16:13 ` [PATCH 4/6] mtd: pxa3xx_nand: Remove redundant NAND sensing Ezequiel Garcia
2015-11-04 21:05 ` Robert Jarzmik [this message]
2015-11-04 16:13 ` [PATCH 5/6] mtd: pxa3xx_nand: Remove dead code Ezequiel Garcia
2015-11-04 21:06 ` Robert Jarzmik
2015-11-04 16:13 ` [PATCH 6/6] mtd: pxa3xx_nand: Gate/ungate the NAND clock in suspend/resume paths Ezequiel Garcia
2015-11-04 21:16 ` Robert Jarzmik
2015-11-04 21:26 ` Ezequiel Garcia
2015-11-04 21:31 ` Robert Jarzmik
2015-11-16 23:04 ` [PATCH 0/6] pxa3xx_nand: Assorted changes Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u6dbhlx.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=antoine.tenart@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).