From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67922C433E0 for ; Fri, 26 Feb 2021 08:00:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0869364EE2 for ; Fri, 26 Feb 2021 08:00:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0869364EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4egbl9fBw3uJloJnCAmgfX1YlJ5htJt6znOP7JqOwMk=; b=vsMWiHkI3gYEiboMkx+/zqRpb HhJNnmusU4JBs9lxy3H8FpuLsm3suI7L24ZK+/RPt4JG4emkcU80Cn1nw0nwYfOkt5bQ29Kacye5s 0IqOiK9CmwJ7uNlfYO15HAofWbTUCdy4wXFZs1alB9Tfcvut1YPJ7C7bmdR6iGBZWFWcCHdAvTIn3 yFMK0z7PF2MSmvzIufVc0WYZfWEK+vBX9VH5za4W8gH9VJF+PVLfkHFQUPLz+7gOxVpPT+jk/MN9L F/J1sqipH9Akw0CNtG5jXBW0v80WlWa0FOZgiaf+/b6pYDg2d/AFe7W2IZNAnaWdIt26EMFmbNe6N KibZuv8Ag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFY1z-0002wR-Jv; Fri, 26 Feb 2021 07:59:23 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFY1t-0002vT-5z; Fri, 26 Feb 2021 07:59:18 +0000 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1614326352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=As1fDYfwKrjxkKoe6zW8X2eDIPaM0LZx7cH6HHLoVWs=; b=gbarmf2Qo6ckmhKhSwECGeeDceFfmjCgsZgbKbhtGOe/ZVnrkkWOYHfk9EX/OvaW1rRLNX 6LDrpfCyyASzExo2fQH3Wk6USh9mNHHsgvWuAZ0ub5xdUjEt5EUT6Vf5DxDGxiufDDA0dD kAFR/HOCf19ewbMg3sDq6t6oq6IKm2/gnMZWkiBdDzKAc77Xol8evKFMxq42TLN5Mzy7Uy RNyNAhsLGReJ53TJjBHzeNEoYHPjH6oRD0CNEhJq1Rdjk6kLa+SaZ2TLx2X4caPC7LziSo LSCkRonnaAQbURvC/8avcnpGuSbPy+eih3OFwIP0fu687A4UJ2O4SpEJooilEQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1614326352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=As1fDYfwKrjxkKoe6zW8X2eDIPaM0LZx7cH6HHLoVWs=; b=oBzcI9hkvNT1WswvpyoaczL8Miw+ylH42+GPWw36ZoSpeUkMPSwywAxm3+Z0cvgGSedn2L iPW16K6EswEd9nAg== To: Petr Mladek Subject: Re: [PATCH next v3 12/15] printk: introduce a kmsg_dump iterator In-Reply-To: <20210225202438.28985-13-john.ogness@linutronix.de> References: <20210225202438.28985-1-john.ogness@linutronix.de> <20210225202438.28985-13-john.ogness@linutronix.de> Date: Fri, 26 Feb 2021 08:59:10 +0100 Message-ID: <87a6rrxnsh.fsf@jogness.linutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210226_025917_443748_14079FEB X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Sergey Senozhatsky , Benjamin Herrenschmidt , Douglas Anderson , Paul Mackerras , Miquel Raynal , "K. Y. Srinivasan" , Thomas Meyer , Vignesh Raghavendra , Wei Liu , Madhavan Srinivasan , Stephen Hemminger , kernel test robot , Michael Ellerman , Anton Vorontsov , clang-built-linux@googlegroups.com, Joel Stanley , Jason Wessel , Anton Ivanov , Wei Li , Haiyang Zhang , Ravi Bangoria , Kees Cook , Alistair Popple , Jeff Dike , Colin Cross , linux-um@lists.infradead.org, Daniel Thompson , Steven Rostedt , Davidlohr Bueso , Nicholas Piggin , Oleg Nesterov , Thomas Gleixner , Andy Shevchenko , Jordan Niethe , Michael Kelley , Christophe Leroy , Tony Luck , kbuild-all@lists.01.org, Pavel Tatashin , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Richard Weinberger , kgdb-bugreport@lists.sourceforge.net, linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hello, Thank you kernel test robot! Despite all of my efforts to carefully construct and test this series, somehome I managed to miss a compile test with CONFIG_MTD_OOPS. That kmsg_dumper does require the dumper parameter so that it can use container_of(). I will discuss this with the printk team. But most likely we will just re-instate the dumper parameter in the callback. I apologize for the lack of care on my part. John Ogness On 2021-02-26, kernel test robot wrote: > Hi John, > > I love your patch! Yet something to improve: > > [auto build test ERROR on next-20210225] > > url: https://github.com/0day-ci/linux/commits/John-Ogness/printk-remove-logbuf_lock/20210226-043457 > base: 7f206cf3ec2bee4621325cfacb2588e5085c07f5 > config: arm-randconfig-r024-20210225 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a921aaf789912d981cbb2036bdc91ad7289e1523) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm cross compiling tool for clang build > # apt-get install binutils-arm-linux-gnueabi > # https://github.com/0day-ci/linux/commit/fc7f655cded40fc98ba5304c200e3a01e8291fb4 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review John-Ogness/printk-remove-logbuf_lock/20210226-043457 > git checkout fc7f655cded40fc98ba5304c200e3a01e8291fb4 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > >>> drivers/mtd/mtdoops.c:277:45: error: use of undeclared identifier 'dumper' > struct mtdoops_context *cxt = container_of(dumper, > ^ >>> drivers/mtd/mtdoops.c:277:45: error: use of undeclared identifier 'dumper' >>> drivers/mtd/mtdoops.c:277:45: error: use of undeclared identifier 'dumper' > 3 errors generated. > > > vim +/dumper +277 drivers/mtd/mtdoops.c > > 4b23aff083649e Richard Purdie 2007-05-29 274 > fc7f655cded40f John Ogness 2021-02-25 275 static void mtdoops_do_dump(enum kmsg_dump_reason reason) > 2e386e4bac9055 Simon Kagstrom 2009-11-03 276 { > 2e386e4bac9055 Simon Kagstrom 2009-11-03 @277 struct mtdoops_context *cxt = container_of(dumper, > 2e386e4bac9055 Simon Kagstrom 2009-11-03 278 struct mtdoops_context, dump); > fc7f655cded40f John Ogness 2021-02-25 279 struct kmsg_dump_iter iter; > fc2d557c74dc58 Seiji Aguchi 2011-01-12 280 > 2e386e4bac9055 Simon Kagstrom 2009-11-03 281 /* Only dump oopses if dump_oops is set */ > 2e386e4bac9055 Simon Kagstrom 2009-11-03 282 if (reason == KMSG_DUMP_OOPS && !dump_oops) > 2e386e4bac9055 Simon Kagstrom 2009-11-03 283 return; > 2e386e4bac9055 Simon Kagstrom 2009-11-03 284 > fc7f655cded40f John Ogness 2021-02-25 285 kmsg_dump_rewind(&iter); > fc7f655cded40f John Ogness 2021-02-25 286 > df92cad8a03e83 John Ogness 2021-02-25 287 if (test_and_set_bit(0, &cxt->oops_buf_busy)) > df92cad8a03e83 John Ogness 2021-02-25 288 return; > fc7f655cded40f John Ogness 2021-02-25 289 kmsg_dump_get_buffer(&iter, true, cxt->oops_buf + MTDOOPS_HEADER_SIZE, > e2ae715d66bf4b Kay Sievers 2012-06-15 290 record_size - MTDOOPS_HEADER_SIZE, NULL); > df92cad8a03e83 John Ogness 2021-02-25 291 clear_bit(0, &cxt->oops_buf_busy); > 2e386e4bac9055 Simon Kagstrom 2009-11-03 292 > c1cf1d57d14922 Mark Tomlinson 2020-09-03 293 if (reason != KMSG_DUMP_OOPS) { > 2e386e4bac9055 Simon Kagstrom 2009-11-03 294 /* Panics must be written immediately */ > 2e386e4bac9055 Simon Kagstrom 2009-11-03 295 mtdoops_write(cxt, 1); > c1cf1d57d14922 Mark Tomlinson 2020-09-03 296 } else { > 2e386e4bac9055 Simon Kagstrom 2009-11-03 297 /* For other cases, schedule work to write it "nicely" */ > 2e386e4bac9055 Simon Kagstrom 2009-11-03 298 schedule_work(&cxt->work_write); > 2e386e4bac9055 Simon Kagstrom 2009-11-03 299 } > c1cf1d57d14922 Mark Tomlinson 2020-09-03 300 } > 4b23aff083649e Richard Purdie 2007-05-29 301 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/