From: Michael Walle <michael@walle.cc>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: tudor.ambarus@microchip.com, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
kernel-team@fb.com
Subject: Re: [PATCH] mtd: spi-nor: Enable locking for n25q128a13
Date: Thu, 01 Jul 2021 12:13:31 +0200 [thread overview]
Message-ID: <87bfecf0836a81e3e6de558776e0b524@walle.cc> (raw)
In-Reply-To: <20210628211729.3625017-1-jonathan.lemon@gmail.com>
Hi Jonathan,
Am 2021-06-28 23:17, schrieb Jonathan Lemon:
> As 4bit block protection patchset for some micron models are merged,
> n25q128a13 also uses 4 bit Block Protection scheme, so enable locking
> for it. Tested it on n25q128a13, the locking functions work well.
>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
> drivers/mtd/spi-nor/micron-st.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/micron-st.c
> b/drivers/mtd/spi-nor/micron-st.c
> index c224e59820a1..f3d19b716b7b 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -146,7 +146,9 @@ static const struct flash_info st_parts[] = {
> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
> SPI_NOR_4BIT_BP | SPI_NOR_BP3_SR_BIT6) },
> { "n25q128a13", INFO(0x20ba18, 0, 64 * 1024, 256,
> - SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
> + SECT_4K | USE_FSR | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
> + SPI_NOR_4BIT_BP | SPI_NOR_BP3_SR_BIT6) },
> { "mt25ql256a", INFO6(0x20ba19, 0x104400, 64 * 1024, 512,
> SECT_4K | USE_FSR | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
For the maintainers: there are no configuration bits which could
change the behavior of the block protection - which we possibly
won't support yet. Thus this looks sane:
Reviewed-by: Michael Walle <michael@walle.cc>
Jonathan, could you also apply my SFDP patch [1] (or use the latest
linux-next) and send me the binary SFDP dump?
-michael
[1] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=241877
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-07-01 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 21:17 [PATCH] mtd: spi-nor: Enable locking for n25q128a13 Jonathan Lemon
2021-07-01 10:13 ` Michael Walle [this message]
2021-07-01 19:10 ` Jonathan Lemon
2021-10-19 10:15 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bfecf0836a81e3e6de558776e0b524@walle.cc \
--to=michael@walle.cc \
--cc=jonathan.lemon@gmail.com \
--cc=kernel-team@fb.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox