From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
"linux-mtd\@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Antoine Tenart <antoine.tenart@free-electrons.com>
Subject: Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts
Date: Mon, 17 Aug 2015 21:15:48 +0200 [thread overview]
Message-ID: <87d1ylafq3.fsf@belgarion.home> (raw)
In-Reply-To: <CAAEAJfAmD5VzA4J4+jwmCirmqfAJcvY8Ac45nupZwGVVb38Vhg@mail.gmail.com> (Ezequiel Garcia's message of "Mon, 17 Aug 2015 16:09:04 -0300")
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> In other words, it seems that we must wake the IRQ thread handler
> _before_ we clear RDDREQ, not after.
>
> So unless I'm completely off, the current patch is right, and a comment
> would be helpful.
Ok Ezequiel, I'll wait for your Tested-by, and respin with something like :
/* Clear all status bit before issuing the next command, which can and
* will alter the status bits and will deserve a new interrupt on its
* own.
*/
> OK, I'll see about testing your four patches on some Armada 370/XP.
Yeah, that would be good.
Cheers.
--
Robert
next prev parent reply other threads:[~2015-08-17 19:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 16:22 [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Robert Jarzmik
2015-08-16 15:29 ` Ezequiel Garcia
2015-08-16 22:18 ` Robert Jarzmik
2015-08-17 19:09 ` Ezequiel Garcia
2015-08-17 19:15 ` Robert Jarzmik [this message]
2015-08-19 0:46 ` Brian Norris
2015-08-19 6:22 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1ylafq3.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=antoine.tenart@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox