From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp07.smtpout.orange.fr ([80.12.242.129] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZRPx4-0005Ys-EA for linux-mtd@lists.infradead.org; Mon, 17 Aug 2015 19:20:11 +0000 From: Robert Jarzmik To: Ezequiel Garcia Cc: Ezequiel Garcia , David Woodhouse , Brian Norris , "linux-mtd\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" , Antoine Tenart Subject: Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts References: <1439396538-13298-1-git-send-email-robert.jarzmik@free.fr> <20150816152924.GA799@laptop.cereza> <87si7iandq.fsf@belgarion.home> Date: Mon, 17 Aug 2015 21:15:48 +0200 In-Reply-To: (Ezequiel Garcia's message of "Mon, 17 Aug 2015 16:09:04 -0300") Message-ID: <87d1ylafq3.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ezequiel Garcia writes: > In other words, it seems that we must wake the IRQ thread handler > _before_ we clear RDDREQ, not after. > > So unless I'm completely off, the current patch is right, and a comment > would be helpful. Ok Ezequiel, I'll wait for your Tested-by, and respin with something like : /* Clear all status bit before issuing the next command, which can and * will alter the status bits and will deserve a new interrupt on its * own. */ > OK, I'll see about testing your four patches on some Armada 370/XP. Yeah, that would be good. Cheers. -- Robert