From: Miquel Raynal <miquel.raynal@bootlin.com>
To: David Regan <dregan@broadcom.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
william.zhang@broadcom.com, anand.gore@broadcom.com,
florian.fainelli@broadcom.com, kamal.dasu@broadcom.com,
dan.beygelman@broadcom.com,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
rafal@milecki.pl, computersforpeace@gmail.com,
frieder.schrempf@kontron.de, vigneshr@ti.com, richard@nod.at,
bbrezillon@kernel.org, kdasu.kdev@gmail.com,
jaimeliao.tw@gmail.com, kilobyte@angband.pl,
jonas.gorski@gmail.com, dgcbueu@gmail.com, dregan@mail.com
Subject: Re: [PATCH] mtd: nand: brcmnand: fix mtd corrected bits stat
Date: Mon, 02 Jun 2025 16:19:35 +0200 [thread overview]
Message-ID: <87ecw2ns3s.fsf@bootlin.com> (raw)
In-Reply-To: <20250530034713.4165309-1-dregan@broadcom.com> (David Regan's message of "Thu, 29 May 2025 20:46:59 -0700")
On 29/05/2025 at 20:46:59 -07, David Regan <dregan@broadcom.com> wrote:
> Currently we attempt to get the amount of flipped bits from a hardware
> location which is reset on every subpage. Instead obtain total flipped
> bits stat from hardware accumulator. In addition identify the correct
> maximum subpage corrected bits.
This change does not feel correct. We gather two statistics:
- the maximum number of bitflips corrected in a single ECC chunk
- the total number of bitflips among the whole page
The most important one is the former, because it may trigger wear
levelling from the top layer (UBI, usually). It feels like you are
breaking this, am I wrong? Would you mind to be more explicit otherwise?
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-06-02 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 3:46 [PATCH] mtd: nand: brcmnand: fix mtd corrected bits stat David Regan
2025-05-30 8:27 ` Jonas Gorski
2025-06-02 6:16 ` David Regan
2025-06-02 14:19 ` Miquel Raynal [this message]
2025-06-05 1:51 ` David Regan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecw2ns3s.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=anand.gore@broadcom.com \
--cc=bbrezillon@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=dan.beygelman@broadcom.com \
--cc=dgcbueu@gmail.com \
--cc=dregan@broadcom.com \
--cc=dregan@mail.com \
--cc=florian.fainelli@broadcom.com \
--cc=frieder.schrempf@kontron.de \
--cc=jaimeliao.tw@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=kamal.dasu@broadcom.com \
--cc=kdasu.kdev@gmail.com \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=noltari@gmail.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox