From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT To: Olof Johansson Cc: Geert Uytterhoeven , arm@kernel.org, Andrew Lunn , Sebastian Hesselbarth , Simon Horman , Magnus Damm , Ralf Baechle , Alex Smith , Brian Norris , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org, linux-mips@linux-mips.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/9] ARM: dts: Add compatible property to "partitions" node References: <1450694033-27717-1-git-send-email-geert+renesas@glider.be> <20151222212350.GF30172@localhost> Date: Wed, 23 Dec 2015 12:04:57 +0100 In-Reply-To: <20151222212350.GF30172@localhost> (Olof Johansson's message of "Tue, 22 Dec 2015 13:23:50 -0800") Message-ID: <87egedfmsm.fsf@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Olof, =20 On mar., d=C3=A9c. 22 2015, Olof Johansson wrote: > Hi, > > On Mon, Dec 21, 2015 at 11:33:44AM +0100, Geert Uytterhoeven wrote: >> Hi, >>=20 >> As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible >> property to "partitions" node"), which is in v4.4-rc6, the "partitions" >> subnode of an SPI FLASH device node must have a compatible property. The >> partitions are no longer detected if it is not present. >>=20 >> However, several DTSes in -next have already been converted to the >> "partitions" subnode without "compatible" property, introduced by >> commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support >> partitions in a special 'partitions' subnode"). Hence all of these are >> now broken in -next, and will be broken in upstream during the merge >> window. > > So, if I understand this correctly, the partitions format was added for v= 4.4, > then this non-backwards compatible change was added in -rc6. But, there w= ere > also DT files that had the new-for-v4.4 partitions nodes in them that then > stopped working in -rc6? At least for the mvebu dts, the change was added for v4.5 not v4.4. Currently it is only in the next branches (and also in your arm-soc tree in next/dt). > > That sounds like a regression, so this should be picked up as fixes > for v4.4. It won't be a regression but a breakage of the bissectability between the patch adding the partition subnode and the one using the compatible "fixed-partitions". If you really want avoiding this you could squash the patches, however from my point of view it's not worth doing it. > > Please confirm that I've understood the setup correctly, and I'll apply t= he > series directly to fixes. I think it won't apply on v4.4 because the partition change was not made at this moment. Gregory --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com