Re: [RFC PATCH 0/3] mtd: spi-nor: Rework flash parameter initialization

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Pratyush Yadav" <pratyush@kernel.org>,
	 "Takahiro Kuwano" <takahiro.kuwano@infineon.com>,
	 "Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	 "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/3] mtd: spi-nor: Rework flash parameter initialization
Date: Mon, 06 Jul 2026 16:16:25 +0200	[thread overview]
Message-ID: <87fr1wkxty.fsf@bootlin.com> (raw)
In-Reply-To: <87zf04kz9s.fsf@bootlin.com> (Miquel Raynal's message of "Mon, 06 Jul 2026 15:45:19 +0200")

On 06/07/2026 at 15:45:19 +02, Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hello,
>
> On 06/07/2026 at 09:33:38 +02, "Michael Walle" <mwalle@kernel.org> wrote:
>
>> On Mon Jul 6, 2026 at 8:24 AM CEST, Miquel Raynal wrote:
>>> On Mon, 01 Jun 2026 14:52:42 +0200, Michael Walle wrote:
>>>> Try to simplify the flash initialization and get rid of the legacy
>>>> handling. As default, all the flags of the in-kernel database are
>>>> taken and amended with the SFDP data.
>>>> 
>>>> This might have the consequence that all the flashes now get a
>>>> RDSFPD opcode which might be an unknown opcode. But that was already
>>>> the case for any flashes which were unknown to the linux kernel. So
>>>> far, there was not a single complaint.
>>>> 
>>>> [...]
>>>
>>> Applied to mtd/fixes, thanks!
>>>
>>> [1/3] mtd: spi-nor: spansion: s25fl256s0: remove SKIP_SFDP flag
>>>       (no commit info)
>>> [2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure
>>>       (no commit info)
>>> [3/3] mtd: spi-nor: rework flash parameter initialization
>>>       (no commit info)
>>>
>>> Patche(s) should be available on mtd/linux.git and will be
>>> part of the next PR (provided that no robot complains by then).
>>
>> Did you see, that there was a v1 of this series? There wasn't many
>> changes for these three patches. Just what Tudor mentioned that the
>> unsupported RDSFDP opcode should be mentioned in the commit message,
>> too.
>>
>> Apart from that, the series now includes fixes that Sashiko found,
>> that is, the rollback in case of a failed SFDP parsing is broken. I
>> can also rebase that on top of these three patches.
>
> Sorry, I actually applied it last Friday and pushed only this morning. I
> will drop the patches and apply v1.

Actually, no.

I did apply it to a local branch for testing, and I forgot about b4
picking it up. So these patches never reached linux-mtd (hence the "no
commit" lines below each commit).

There are two ways forward:
- We consider the whole series for mtd/fixes (which I will likely send
  next week) and I take v1.
- We keep the series for spi-nor/next and I let someone else apply it
  there.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/