Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Guanglei Zhu <zhugl3@xiaopeng.com>,
	 Harvey Hunt <harveyhuntnexus@gmail.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mips@vger.kernel.org, linux-mtd@lists.infradead.org,
	 linux-kernel@vger.kernel.org,  Weibin Liu <liuwb@xiaopeng.com>,
	 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 1/2] mtd: rawnand: ingenic: validate BCH error index in jz4725b_correct()
Date: Mon, 16 Nov 2026 18:06:30 +0100	[thread overview]
Message-ID: <87h5hgpuy1.fsf@bootlin.com> (raw)
In-Reply-To: <91b7fc2fd16f1089449701c002dd33e191894871.camel@crapouillou.net> (Paul Cercueil's message of "Fri, 06 Nov 2026 15:37:47 +0100")

On 06/11/2026 at 15:37:47 +01, Paul Cercueil <paul@crapouillou.net> wrote:

> Hi,
>
> Le jeudi 05 novembre 2026 à 12:24 +0800, Guanglei Zhu a écrit :
>> From: Weibin Liu <liuwb@xiaopeng.com>
>> 
>> The JZ4725B BCH controller reports each corrected bit error as an
>> index into the codeword it was asked to decode, in the INDEX0/INDEX1
>> fields of the BCH_BHERR registers. These fields are 13 bits wide, but
>> nothing in jz4725b_correct() checks the reported index against the
>> size of the data buffer being corrected:
>> 
>>     buf[(bit >> 3)] ^= BIT(bit & 0x7);
>> 
>> With data or ECC coming from an untrusted flash, the decoder can
>> report an index that points past the end of the data buffer, and the
>> above statement then flips a bit outside the buffer.
>> 
>> Skip the correction when the reported index does not point into
>> the data area.  A bitflip in the parity bytes does not affect the
>> data, so rejecting the page for it would fail reads that are
>> perfectly correctable, and an index beyond the codeword has no
>> buffer to update in the first place.
>> 
>> Fixes: 3e6ac2ad90b3 ("mtd: rawnand: ingenic: Add support for the JZ4725B")
>> Signed-off-by: Weibin Liu <liuwb@xiaopeng.com>
>> ---
>> Changes in v2: skip the correction for an index that does not point
>> into the data area instead of failing the page with -EBADMSG.  A
>> correctable bitflip in the ECC bytes leaves the data valid, and the
>> early exit also dropped the error entries that followed it.  This
>> matches how jz4740_ecc_correct() treats its indexes.
>> 
>> Verified with a userspace replica of the correction loop: with
>> params->size = 512, an index of 4099 (parity area) followed by a
>> data-area index of 100 in the same BHERR register is now corrected
>> (v1 returned -EBADMSG and left the data error unfixed), the field
>> maximum (0x1fff) produces no write outside the buffer, and in-range
>> indexes keep correcting as before.
>
> What bothers me, and maybe it's just me not knowing NAND that well: wouldn't a
> bit-flip in the parity area cause a cascade of false-positives in the
> data too,

No, because the data vs. parity split only exist because our human
brains prefer when the room is tidy, data with data, parity with
parity. But in practice bitflips can happen anywhere in the data or in
the so called parity area, it's the same pool of bits for the
algorithm. It does not matter where bitflips are as long as the
threshold is not exceeded.

If I remember well, in the hamming software ECC implementation (under
lib/), we do not even bother fixing the bitflips in the parity area.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2026-11-16 17:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  4:01 [PATCH 1/2] mtd: rawnand: ingenic: validate BCH error index in jz4725b_correct() Guanglei Zhu
2026-11-05  4:01 ` [PATCH 2/2] mtd: rawnand: ingenic: validate BCH error index in jz4780_correct() Guanglei Zhu
2026-11-05  4:15   ` sashiko-bot
2026-11-05  4:10 ` [PATCH 1/2] mtd: rawnand: ingenic: validate BCH error index in jz4725b_correct() sashiko-bot
2026-11-05  4:24 ` [PATCH v2 " Guanglei Zhu
2026-11-05  4:24   ` [PATCH v2 2/2] mtd: rawnand: ingenic: validate BCH error index in jz4780_correct() Guanglei Zhu
2026-11-06 14:37   ` [PATCH v2 1/2] mtd: rawnand: ingenic: validate BCH error index in jz4725b_correct() Paul Cercueil
2026-11-16 17:06     ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5hgpuy1.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=harveyhuntnexus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=liuwb@xiaopeng.com \
    --cc=paul@crapouillou.net \
    --cc=richard@nod.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vigneshr@ti.com \
    --cc=zhugl3@xiaopeng.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox