Re: [PATCH v2 1/2] dt-bindings: mtd: Add realtek,rtl9301-ecc

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hello,

On 28/08/2025 at 10:34:07 -04, Markus Stockhausen <markus.stockhausen@gmx.de> wrote:

> Add a dtschema for the ECC engine on the Realtek RTL93xx SoCs.
> The engine supports BCH6 and BCH12 parity for 512 byte blocks.
>
> Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
> ---
> Changes in v2:
> - change cells from 2 to 1 (only 32 bit hardware)
> ---
>  .../bindings/mtd/realtek,rtl9301-ecc.yaml     | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/realtek,rtl9301-ecc.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/realtek,rtl9301-ecc.yaml b/Documentation/devicetree/bindings/mtd/realtek,rtl9301-ecc.yaml
> new file mode 100644
> index 000000000000..1b34d79007a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/realtek,rtl9301-ecc.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/realtek,rtl9301-ecc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek SoCs NAND ECC engine
> +
> +maintainers:
> +  - Markus Stockhausen <markus.stockhausen@gmx.de>
> +
> +properties:
> +  compatible:
> +    const: realtek,rtl9301-ecc
> +
> +  reg:
> +    maxItems: 1

This controller has an interrupt which must be described. It does not
matter if you use it or not for performance reasons in the driver. Just
don't mark it required below.

Also, no clocks seems suspicious. But maybe they are "hidden".

> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/