Re: [PATCH v2] mtd: nand: brcmnand: fix mtd corrected bits stat

David Regan
2025-06-19T18:42:52Z

Hi Miquèl,

On Wed, Jun 18, 2025 at 2:07 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hello David

...

> So far the reporting looks good (and the nandflipbits output looks
> correct as well).
>
> > [ 676.408441] mtd_nandbiterrs: Inserted biterror @ 2/5
> > [ 676.413411] mtd_nandbiterrs: rewrite page
> > [ 676.418122] mtd_nandbiterrs: read_page
> > [ 676.422267] mtd_nandbiterrs: verify_page
> > [ 676.426194] mtd_nandbiterrs: Error: page offset 0, expected 25, got 00
> > [ 676.432727] mtd_nandbiterrs: Error: page offset 1, expected a5, got 00
> > [ 676.439260] mtd_nandbiterrs: Error: page offset 2, expected 65, got 05
> > [ 676.445868] mtd_nandbiterrs: ECC failure, read data is incorrect
> > despite read success
>
> Here however there is something wrong. We do expect a read failure,
> instead of returning wrong data. There is still a problem, I do not know
> if this problem was there before though, but this must be fixed.
>

Thank you for highlighting this issue, I will investigate.

>
> Hello Florian, if you have time, I'd welcome you opinion on this patch :)
>
> Cheers,
> Miquèl

Thanks!

-Dave