From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-mtd\@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Antoine Tenart <antoine.tenart@free-electrons.com>
Subject: Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts
Date: Wed, 19 Aug 2015 08:22:05 +0200 [thread overview]
Message-ID: <87io8b94s2.fsf@belgarion.home> (raw)
In-Reply-To: <20150819004629.GS60523@google.com> (Brian Norris's message of "Tue, 18 Aug 2015 17:46:29 -0700")
Brian Norris <computersforpeace@gmail.com> writes:
> Hi Robert,
>
> On Mon, Aug 17, 2015 at 09:15:48PM +0200, Robert Jarzmik wrote:
>> Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
>> > So unless I'm completely off, the current patch is right, and a comment
>> > would be helpful.
>> Ok Ezequiel, I'll wait for your Tested-by, and respin with something like :
>>
>> /* Clear all status bit before issuing the next command, which can and
>> * will alter the status bits and will deserve a new interrupt on its
>> * own.
>> */
>
> To be clear: I should hold off on this patch?
If you can hold until this evening (ie. in 12h), I'll post the same version of
the patch with Ezequiel's comment, and Ack/Test if he provides it.
If you have to decide in the next few hours, take it, this fix should land in
v4.3.
> I'm going to try to clear my queue of things that are simple/obvious
> and/or fix bugs (I think you spoke up about a different pxa3xx_nand
> bugfix which I will try to find). There's too big a backlog for me to
> get through everything for the merge window...
I'll resend my pxa3xx-nand backlog this evening for fixes I have on mind which
are simple fixes :
- this one (random command timeouts)
- Antoine's one (resent yesterday)
- my fix for probe (mtd: nand: pxa3xx_nand: fix early spurious interrupt)
If you can wait this evening it will spare you digging through your mails.
Or alternatively Ezequiel, if you want to aggregate the patches because you have
others on mind also, please feel free to overtake this from me before my evening :)
Cheers.
--
Robert
prev parent reply other threads:[~2015-08-19 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 16:22 [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Robert Jarzmik
2015-08-16 15:29 ` Ezequiel Garcia
2015-08-16 22:18 ` Robert Jarzmik
2015-08-17 19:09 ` Ezequiel Garcia
2015-08-17 19:15 ` Robert Jarzmik
2015-08-19 0:46 ` Brian Norris
2015-08-19 6:22 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io8b94s2.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=antoine.tenart@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox