From: Robert Jarzmik <robert.jarzmik@free.fr>
To: dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/4] drivers/mtd: docg3 add protection against concurrency
Date: Wed, 21 Mar 2012 21:24:14 +0100 [thread overview]
Message-ID: <87iphx8zyp.fsf@free.fr> (raw)
In-Reply-To: <1332243749.11468.21.camel@sauron.fi.intel.com> (Artem Bityutskiy's message of "Tue, 20 Mar 2012 13:42:29 +0200")
Artem Bityutskiy <dedekind1@gmail.com> writes:
> On Mon, 2012-03-19 at 23:32 +0100, Robert Jarzmik wrote:
>> +static void cascade_lock(struct docg3 *docg3)
>> +{
>> + mutex_lock(&docg3->cascade->lock);
>> +}
>> +
>> +static void cascade_unlock(struct docg3 *docg3)
>> +{
>> + mutex_unlock(&docg3->cascade->lock);
>> +}
>
> Please, do not introduce that trivial wrappers - they are useless and
> only hurt readability. Open-coded mutex_lock()/mutex_unlock() is more
> readable.
OK for V2.
I'll await comments for 3 or 4 days before releasing V2.
Cheers.
--
Robert
next prev parent reply other threads:[~2012-03-21 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 22:32 [PATCH 0/4] Fixes for docg3 to enable ubifs over docg3 Robert Jarzmik
2012-03-19 22:32 ` [PATCH 1/4] drivers/mtd: docg3 fix inbound calculations Robert Jarzmik
2012-03-19 22:32 ` [PATCH 2/4] drivers/mtd: docg3 increase write/erase timeout Robert Jarzmik
2012-03-19 22:32 ` [PATCH 3/4] drivers/mtd: docg3 refactor cascade floors structure Robert Jarzmik
2012-03-19 22:32 ` [PATCH 4/4] drivers/mtd: docg3 add protection against concurrency Robert Jarzmik
2012-03-20 11:42 ` Artem Bityutskiy
2012-03-21 20:24 ` Robert Jarzmik [this message]
2012-03-22 11:48 ` Artem Bityutskiy
2012-03-22 20:01 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iphx8zyp.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox