* DocG3 patch
@ 2011-09-18 10:03 Robert Jarzmik
2011-09-19 5:14 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Robert Jarzmik @ 2011-09-18 10:03 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: dwmw2, linux-mtd
Hello Artem,
It's been 2 months, and I had no news.
The DocG3 driver was submitted and not reviewed in [1] and [2].
Could you merge the patch into your tree please (patch in [2]) ?
Cheers.
--
Robert
[1] http://comments.gmane.org/gmane.linux.drivers.mtd/35284
[2] http://comments.gmane.org/gmane.linux.drivers.mtd/36146
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: DocG3 patch
2011-09-18 10:03 DocG3 patch Robert Jarzmik
@ 2011-09-19 5:14 ` Artem Bityutskiy
2011-09-19 18:01 ` Robert Jarzmik
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2011-09-19 5:14 UTC (permalink / raw)
To: Robert Jarzmik; +Cc: dwmw2, linux-mtd
On Sun, 2011-09-18 at 12:03 +0200, Robert Jarzmik wrote:
> Hello Artem,
>
> It's been 2 months, and I had no news.
> The DocG3 driver was submitted and not reviewed in [1] and [2].
>
> Could you merge the patch into your tree please (patch in [2]) ?
Oh, I missed your v2 completely.
The problem I see with this driver is that it uses sysfs interfaces for
debugging purposes. You should not do this - we have debugfs for stuff
like that. I suggest you to just kill sysfs interfaces and re-send your
patch. You can later add debugfs interfaces instead.
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: DocG3 patch
2011-09-19 5:14 ` Artem Bityutskiy
@ 2011-09-19 18:01 ` Robert Jarzmik
0 siblings, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2011-09-19 18:01 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd, dwmw2
Artem Bityutskiy <dedekind1@gmail.com> writes:
> On Sun, 2011-09-18 at 12:03 +0200, Robert Jarzmik wrote:
>> Hello Artem,
>>
>> It's been 2 months, and I had no news.
>> The DocG3 driver was submitted and not reviewed in [1] and [2].
>>
>> Could you merge the patch into your tree please (patch in [2]) ?
>
> Oh, I missed your v2 completely.
>
> The problem I see with this driver is that it uses sysfs interfaces for
> debugging purposes. You should not do this - we have debugfs for stuff
> like that. I suggest you to just kill sysfs interfaces and re-send your
> patch. You can later add debugfs interfaces instead.
Converted sysfs -> debufs, and resent in V3.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-19 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-18 10:03 DocG3 patch Robert Jarzmik
2011-09-19 5:14 ` Artem Bityutskiy
2011-09-19 18:01 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox